Fix PlayOptions YAML round trips - #2453
Open
Old-Ding wants to merge 2 commits into
Open
Conversation
The encoder writes action filters, loop, and remapping options, but the decoder ignored those keys. Decode every existing encoded key and add complete text YAML round-trip coverage for the current converter contract. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
Use rclcpp's standard Duration message conversion so negative nanoseconds are normalized to a non-negative nanosecond field. This keeps the default PlayOptions acknowledgement timeout round-trippable through text YAML. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions_to_filterandexclude_actionsYAML keysloopandtopic_remapping_optionsYAML keysrclcpp::Durationvalues with the standard ROSsec/nanosecrepresentationTesting
wait_acked_timeout = -1nsencodes assec: -1, nsec: 999999999and round-tripsament_copyrighton the new testgit diff --checkThe repository-native C++ tests were not run locally because this Windows environment does not have the ROS 2 build dependencies or colcon. Repository CI covers the new round-trip tests.