feat(rosbag2_transport): add progress reporting to ros2 bag convert - #2438
Open
Sourav0607 wants to merge 1 commit into
Open
feat(rosbag2_transport): add progress reporting to ros2 bag convert#2438Sourav0607 wants to merge 1 commit into
Sourav0607 wants to merge 1 commit into
Conversation
Sourav0607
force-pushed
the
rolling-bag-convert-progress
branch
from
May 30, 2026 00:10
02f7616 to
c42a276
Compare
cwit-vcas
reviewed
Jun 1, 2026
Sourav0607
force-pushed
the
rolling-bag-convert-progress
branch
from
June 1, 2026 12:24
c42a276 to
f8d6b12
Compare
cwit-vcas
reviewed
Jun 1, 2026
Sourav0607
force-pushed
the
rolling-bag-convert-progress
branch
from
June 1, 2026 12:38
f8d6b12 to
788d8eb
Compare
Print conversion progress as percentage and message count during ros2 bag convert to help users gauge how long large bag conversions will take. Progress is printed at each 1% increment. Fixes ros2#2435 Signed-off-by: Sourav Anil Hawaldar <sourav.hawaldar@gmail.com>
Sourav0607
force-pushed
the
rolling-bag-convert-progress
branch
from
June 5, 2026 16:28
788d8eb to
8966b1c
Compare
cwit-vcas
reviewed
Jun 8, 2026
cwit-vcas
left a comment
cwit-vcas
left a comment
There was a problem hiding this comment.
LGTM, but I do not have any power to merge.
Author
|
@MichaelOrlov could you please review this PR when you get a chance? |
cwit-vcas
reviewed
Jun 9, 2026
| auto topic_outputs = setup_topic_filtering(input_bags, output_bags); | ||
|
|
||
| // Sum total message count across all input bags for progress reporting | ||
| // Sum total message count across all input bags for progress reporting |
MichaelOrlov
reviewed
Jul 6, 2026
MichaelOrlov
left a comment
MichaelOrlov
left a comment
Contributor
There was a problem hiding this comment.
@Sourav0607 Thank you for you interest to contributing and making Rosbag2 better.
I didn't have time to run through a thorough review.
However, for a high level design approach I would expect an implementation of the progress bar in a separate class similar to how it was made in the #1836 PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add progress reporting to
ros2 bag convertso users can gauge how longlarge bag conversions will take.
Previously, the convert command gave no feedback during conversion, making
it impossible to estimate remaining time for large bags.
Changes:
Example output:
Fixes #2435
Is this user-facing behavior change?
Yes. Users will now see progress output when running
ros2 bag convert.Did you use Generative AI?
No.
Additional Information
Tested manually with a recorded bag on Rolling (Lyrical Luth tarball).