Fix for possible freeze in Recorder::stop() - #1381
Merged
Merged
Conversation
- It was possible a freeze in recorder due to the race condition when calling Recorder::stop() while event publisher thread hasn't been fully started yet. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
requested review from
emersonknapp and
hidmic
and removed request for
a team
June 9, 2023 05:00
emersonknapp
reviewed
Jun 9, 2023
emersonknapp
approved these changes
Jun 9, 2023
emersonknapp
left a comment
emersonknapp
left a comment
Collaborator
There was a problem hiding this comment.
One nitpick, otherwise looks fine
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Contributor
Author
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/41a006aa45ebe367963c3e7156a1f583/raw/baee2f29cb956adfb2b348ce59d7c978a7266da7/ros2.repos
|
delete-merged-branch
Bot
deleted the
morlov/fix_for_freeze_in_recorder_stop
branch
June 10, 2023 20:38
Contributor
Author
|
https://github.com/Mergifyio backport iron |
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Jun 10, 2023
* Fix for possible freeze in Recorder::stop() - It was possible a freeze in recorder due to the race condition when calling Recorder::stop() while event publisher thread hasn't been fully started yet. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Move event_publisher_thread_wake_cv_.notify_all() out of the mutex lock Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit c6cc69a)
Contributor
Author
|
https://github.com/Mergifyio backport humble |
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Jun 10, 2023
* Fix for possible freeze in Recorder::stop() - It was possible a freeze in recorder due to the race condition when calling Recorder::stop() while event publisher thread hasn't been fully started yet. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Move event_publisher_thread_wake_cv_.notify_all() out of the mutex lock Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit c6cc69a) # Conflicts: # rosbag2_transport/src/rosbag2_transport/recorder.cpp
MichaelOrlov
pushed a commit
that referenced
this pull request
Jun 13, 2023
* Fix for possible freeze in Recorder::stop() - It was possible a freeze in recorder due to the race condition when calling Recorder::stop() while event publisher thread hasn't been fully started yet. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Move event_publisher_thread_wake_cv_.notify_all() out of the mutex lock Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit c6cc69a) Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
pushed a commit
that referenced
this pull request
Jun 13, 2023
* Fix for possible freeze in Recorder::stop() - It was possible a freeze in recorder due to the race condition when calling Recorder::stop() while event publisher thread hasn't been fully started yet. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Move event_publisher_thread_wake_cv_.notify_all() out of the mutex lock Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit c6cc69a) # Conflicts: # rosbag2_transport/src/rosbag2_transport/recorder.cpp
MichaelOrlov
pushed a commit
that referenced
this pull request
Jun 18, 2023
* Fix for possible freeze in Recorder::stop() - It was possible a freeze in recorder due to the race condition when calling Recorder::stop() while event publisher thread hasn't been fully started yet. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Move event_publisher_thread_wake_cv_.notify_all() out of the mutex lock Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit c6cc69a) # Conflicts: # rosbag2_transport/src/rosbag2_transport/recorder.cpp
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-06-15/32038/1 |
MichaelOrlov
pushed a commit
that referenced
this pull request
Jun 27, 2023
* Fix for possible freeze in Recorder::stop() - It was possible a freeze in recorder due to the race condition when calling Recorder::stop() while event publisher thread hasn't been fully started yet. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Move event_publisher_thread_wake_cv_.notify_all() out of the mutex lock Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit c6cc69a) # Conflicts: # rosbag2_transport/src/rosbag2_transport/recorder.cpp
MichaelOrlov
pushed a commit
that referenced
this pull request
Jun 28, 2023
…#1388) * Fix for possible freeze in Recorder::stop() (#1381) * Fix for possible freeze in Recorder::stop() - It was possible a freeze in recorder due to the race condition when calling Recorder::stop() while event publisher thread hasn't been fully started yet. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Move event_publisher_thread_wake_cv_.notify_all() out of the mutex lock Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit c6cc69a) # Conflicts: # rosbag2_transport/src/rosbag2_transport/recorder.cpp * Resolve merge conflicts Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Remove `in_recording_` variable for ABI compatibility Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was possible a freeze in the recorder due to the race condition when calling
Recorder::stop()while the event publisher thread hasn't been fully started yet.