Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

backport transport_tcp bugfix to Kinetic - #1069

Closed
andyli wants to merge 2 commits into
ros:kinetic-develfrom
andyli:transport_tcp_kinetic
Closed

backport transport_tcp bugfix to Kinetic#1069
andyli wants to merge 2 commits into
ros:kinetic-develfrom
andyli:transport_tcp_kinetic

Conversation

@andyli

@andyli andyli commented May 29, 2017

Copy link
Copy Markdown

Here I cherrypicked the fix in #1050 and applied it to the kinetic-devel branch.
Tested on my machine in WSL:

rosrun turtlesim turtle_teleop_key
rostopic echo /turtle1/cmd_vel

Everything works as expected.


For people who want to get this now:

git clone -b transport_tcp_kinetic https://github.com/andyli/ros_comm.git
ln -s /abs/path/to/ros_comm ~/catkin_ws
cd ~/catkin_ws
catkin_make
catkin_make install

# you may add this line to ~/.bashrc
source ~/catkin_ws/devel/setup.bash

bxwllzz and others added 2 commits May 29, 2017 16:21
* Fix bug in transport_tcp

It assumes that the `connect` method of non-blocking scoket should return -1 and `last_socket_error()` should return `ROS_SOCKETS_ASYNCHRONOUS_CONNECT_RETURN`(=`EINPROGRESS`). 
But a non-blocking `connect` can return 0 when TCP connection to 127.0.0.1 (localhost).
[http://stackoverflow.com/questions/14027326/can-connect-return-0-with-non-blocing-socket](http://stackoverflow.com/questions/14027326/can-connect-return-0-with-non-blocing-socket)

* Modify code format

Modify code format
@dirk-thomas

Copy link
Copy Markdown
Member

Thank you. But all backports will happen before the next Kinetic release in a single pull request (similar to e.g. #1008). Therefore I will close this for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants