This repository was archived by the owner on May 31, 2025. It is now read-only.
Backport fix rosbag::View::iterator copy assignment operator - #1020
Closed
sbarthelemy wants to merge 2 commits into
Closed
Backport fix rosbag::View::iterator copy assignment operator#1020sbarthelemy wants to merge 2 commits into
sbarthelemy wants to merge 2 commits into
Conversation
the compiler-generated copy assignment operator did lead to segfault and memory leaks.
Member
|
There is no need to make a pull request for backports. Before the next Indigo release all commits on the latest branch are considered and cherry picked in a single PR like #1008. Therefore I will close this. |
Contributor
Author
|
ok, sorry for the noise. |
Member
|
No proble, this is not written down anywhere for people to discover. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #1017.