Skip to content

ros-generate-recipe.sh: Do not set --yocto-release when using development release #1814

Description

@robwoolley

When building the next Yocto development release (using the master branch) the ros-generate-recipe.sh incorrectly specifies the previous Yocto rlease:

Running: /home/runner/work/meta-ros/meta-ros/superflore/venv/bin/superflore-gen-oe-recipes --dry-run --no-branch --ros-distro lyrical --yocto-release wrynose --output-repository-path . --upstream-branch HEAD --skip-keys libatomic 

The shell script calls superflore with --yocto-release automatically set (https://github.com/ros/meta-ros/blob/master/scripts/ros-generate-recipes.sh#L192). It grabs the Yocto release version from the layer.conf of meta-ros2. However, during the development cycle this is set to the previous release and only updated when a new Yocto release is released.

In theory the script should omit --yocto-release when 1 of these conditions occur:

  • the master branch is being used
  • the detected release value doesn't match the branch name

I need to think about what the appropriate fix is.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions