[tmva][sofie] Remove IO support for RModel#22733
Open
guitargeek wants to merge 1 commit into
Open
Conversation
guitargeek
force-pushed
the
rmodel_io
branch
3 times, most recently
from
0ce128b to
3c90819
Compare
RModel is an intermediate model representation for SOFIE on the way to the C++ code emit, so a priori there is no need to support IO for it on the ROOT side. The RModel is read in from serialized ONNX models anyway, so the RModel IO is redundant. The edge case where RModel IO *could* be useful is to serialize neural networks that are not serializable by ONNX, but I'd argue that we should not enter the game of general model serialization unless there is a request from the user community, in which case we can re-introduce IO capability with minimal changes or consider other solutions. This commit also removes the unit tests of code emit from ROOT files with RModel, which were 1) out-of-sync with the operator coverage of SOFIE and 2) redundant with the ONNX tests, because the ONNX parser takes the route via the RModel anyway (modulo the small custom streamer implementation). Furthermore, IO of experimental classes should not be encouraged and supported if not absolutely needed, because ROOT is not commiting to backwards compatibility for experimental classes.
Test Results 23 files 23 suites 3d 16h 45m 2s ⏱️ For more details on these failures, see this check. Results for commit a675f31. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RModel is an intermediate model representation for SOFIE on the way to the C++ code emit, so a priori there is no need to support IO for it on the ROOT side. The RModel is read in from serialized ONNX models anyway, so the RModel IO is redundant.
The edge case where RModel IO could be useful is to serialize neural networks that are not serializable by ONNX, but I'd argue that we should not enter the game of general model serialization unless there is a request from the user community, in which case we can re-introduce IO capability with minimal changes or consider other solutions.
This commit also removes the unit tests of code emit from ROOT files with RModel, which were 1) out-of-sync with the operator coverage of SOFIE and 2) redundant with the ONNX tests, because the ONNX parser takes the route via the RModel anyway (modulo the small custom streamer implementation).
Furthermore, IO of experimental classes should not be encouraged and supported if not absolutely needed, because ROOT is not commiting to backwards compatibility for experimental classes.