Skip to content

Hover unblurs a blurred video the same way as an image - #1058

Open
forest-savage1234 wants to merge 3 commits into
roostorg:mainfrom
forest-savage1234:video-hover-unblur
Open

Hover unblurs a blurred video the same way as an image#1058
forest-savage1234 wants to merge 3 commits into
roostorg:mainfrom
forest-savage1234:video-hover-unblur

Conversation

@forest-savage1234

@forest-savage1234 forest-savage1234 commented Aug 24, 2026

Copy link
Copy Markdown

Hover unblurs a blurred video the same way as an image

Closes #524.

Context & Requests for Reviewers

Images already use Tailwind hover:blur-none. Videos only drop blur when playing is true, so hover does nothing unless the reviewer hits play or turns blurring off. ThatKoffe named hover.

This puts group on the outer player wrapper and group-hover:blur-none on the blurred inner div so hovering the play button or the video unblurs, matching the image control. Play-to-unblur is unchanged. Wellness docs still say play-to-unblur only. Juliet pointed at #194; that is a different still-open migration, not this PR.

Tests

Dest check, Ubuntu Node v24.18.0, vitest 4.1.10:

✓ src/webpages/dashboard/mrt/manual_review_job/ManualReviewJobContentBlurableVideo.test.tsx (1 test) 272ms
Test Files  1 passed (1)
     Tests  1 passed (1)

The test renders a blurred video and asserts group on the wrapper plus group-hover:blur-none and blur-sm on the inner player. No live job with a video was hovered.

(Optional) Rollout Plan

Not this PR. Local UI hover class only.

Checklist

Only check items that apply to this PR; leave the rest unchecked.

  • If you changed anything user-facing (i.e. user interface or APIs):
    Did you update the CHANGELOG.md and related docs?

  • If you changed server/models/**/{ContentTypeModel,ActionModel,RuleModel,PolicyModel}.ts:
    Did you update the corresponding history tables and their triggers?

  • If you changed db/src/scripts/** and used CREATE TABLE, ADD COLUMN, or ALTER COLUMN:
    Are as many columns marked NOT NULL as possible? If some columns can sometimes be null depending on other columns, are there CHECK constraints capturing those relationships, and are these also reflected using unions in the associated Kysely types?

  • If you added a new signal in server/services/signalsService/signals/**:
    Did you classify every error case as a permanent error (SignalPermanentError, no retry) or a normal error (retryable)? Any case where the signal can't determine a score should be a SignalPermanentError.

User-facing. CHANGELOG has the Review Console line. History / db scripts / signals are not this PR. Wellness docs were not rewritten.

Files

  1. client/src/webpages/dashboard/mrt/manual_review_job/ManualReviewJobContentBlurableVideo.tsx
  2. client/src/webpages/dashboard/mrt/manual_review_job/ManualReviewJobContentBlurableVideo.test.tsx
  3. CHANGELOG.md

Out of scope

How to review

On a job with a blurred video, hover the player. Blur should lift and return when the cursor leaves, without pressing play. Images should still behave as they do.

I am a volunteer. Thank you for the time. I am trying to become more useful on this work, so I welcome a critical look. If this is the wrong cut, or you want me to stand down, say so and I will recut from notes.

Signed-off-by: Forest Savage <forestsavage03@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 59 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fb8094e5-3da1-4245-95b9-325c30611d1c

📥 Commits

Reviewing files that changed from the base of the PR and between a700601 and cd0d42a.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • client/src/webpages/dashboard/mrt/manual_review_job/ManualReviewJobContentBlurableVideo.test.tsx
  • client/src/webpages/dashboard/mrt/manual_review_job/ManualReviewJobContentBlurableVideo.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Forest Savage <forestsavage03@gmail.com>
@forest-savage1234
forest-savage1234 marked this pull request as ready for review August 24, 2026 07:38
@forest-savage1234
forest-savage1234 requested review from a team and julietshen as code owners August 24, 2026 07:38
@forest-savage1234

Copy link
Copy Markdown
Author

Thank you for the time on this review. This only unblurs a video on hover the same way as an image. If that is the wrong cut, say so and I will recut from notes.

Signed-off-by: Forest Savage <forestsavage03@gmail.com>

Co-Authored-By: OpenAI Codex <noreply@openai.com>
@taobojlen

Copy link
Copy Markdown
Contributor

thanks for this contribution @forest-savage1234 !

i think we should probably focus on #194, which would conflict with this change here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hovering over a blurred video does not deblur

2 participants