Hover unblurs a blurred video the same way as an image - #1058
Hover unblurs a blurred video the same way as an image#1058forest-savage1234 wants to merge 3 commits into
Conversation
Signed-off-by: Forest Savage <forestsavage03@gmail.com>
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Forest Savage <forestsavage03@gmail.com>
|
Thank you for the time on this review. This only unblurs a video on hover the same way as an image. If that is the wrong cut, say so and I will recut from notes. |
Signed-off-by: Forest Savage <forestsavage03@gmail.com> Co-Authored-By: OpenAI Codex <noreply@openai.com>
|
thanks for this contribution @forest-savage1234 ! i think we should probably focus on #194, which would conflict with this change here. |
Hover unblurs a blurred video the same way as an image
Closes #524.
Context & Requests for Reviewers
Images already use Tailwind
hover:blur-none. Videos only drop blur whenplayingis true, so hover does nothing unless the reviewer hits play or turns blurring off. ThatKoffe named hover.This puts
groupon the outer player wrapper andgroup-hover:blur-noneon the blurred inner div so hovering the play button or the video unblurs, matching the image control. Play-to-unblur is unchanged. Wellness docs still say play-to-unblur only. Juliet pointed at #194; that is a different still-open migration, not this PR.Tests
Dest check, Ubuntu Node v24.18.0, vitest 4.1.10:
The test renders a blurred video and asserts
groupon the wrapper plusgroup-hover:blur-noneandblur-smon the inner player. No live job with a video was hovered.(Optional) Rollout Plan
Not this PR. Local UI hover class only.
Checklist
Only check items that apply to this PR; leave the rest unchecked.
If you changed anything user-facing (i.e. user interface or APIs):
Did you update the CHANGELOG.md and related docs?
If you changed
server/models/**/{ContentTypeModel,ActionModel,RuleModel,PolicyModel}.ts:Did you update the corresponding history tables and their triggers?
If you changed
db/src/scripts/**and usedCREATE TABLE,ADD COLUMN, orALTER COLUMN:Are as many columns marked
NOT NULLas possible? If some columns can sometimes be null depending on other columns, are thereCHECKconstraints capturing those relationships, and are these also reflected using unions in the associated Kysely types?If you added a new signal in
server/services/signalsService/signals/**:Did you classify every error case as a permanent error (
SignalPermanentError, no retry) or a normal error (retryable)? Any case where the signal can't determine a score should be aSignalPermanentError.User-facing. CHANGELOG has the Review Console line. History / db scripts / signals are not this PR. Wellness docs were not rewritten.
Files
client/src/webpages/dashboard/mrt/manual_review_job/ManualReviewJobContentBlurableVideo.tsxclient/src/webpages/dashboard/mrt/manual_review_job/ManualReviewJobContentBlurableVideo.test.tsxCHANGELOG.mdOut of scope
docs/user/review-console.mdstill says play-to-unblur)is_demo_orgcolumn and app code #628 / Downloading a "recent decision" CSV does not show progress #551 / Replace lodash with native JavaScript #202 / Document deployment considerations for popular hosting providers #704 / Document base infra requirements/recommendations for deployment #703BLUR_LEVELSor wellness defaultsHow to review
On a job with a blurred video, hover the player. Blur should lift and return when the cursor leaves, without pressing play. Images should still behave as they do.
I am a volunteer. Thank you for the time. I am trying to become more useful on this work, so I welcome a critical look. If this is the wrong cut, or you want me to stand down, say so and I will recut from notes.