Skip to content

Feature: Make prometheus optional #385

Description

@Kixunil

Is your feature request related to a problem? Please describe.
Some people have trouble building electrs (see e.g. #252) because of sysconf dependency, some may not need it and thus avoiding compilation time and potential attack surface may be preferred.

Describe the solution you'd like
Make prometheus optional using a Cargo feature (default on, I guess) and document it. Packagers are still encouraged to include it. Put all related code into a single module to cut it out cleanly and create an empty module with empty structs and no-op methods.

Describe alternatives you've considered

  • Try to fix lib bugs - nice but it's still more moving parts than necessary for many people.
  • Rewrite dependencies somehow to bypass C/OS APIs - difficult, I guess?
  • Do not support niche platforms

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions