Repository navigation
fix: preserve scheme when forwarding host-header requests, refuse self-forwarding - #4
Merged
Merged
Conversation
…t https Host-header fallback routing hardcoded https for every upstream URL, so any plain-http request to the proxy failed with "io error: error sending request for url (https://...)". Resolve the upstream with the scheme the client actually used (URI scheme, defaulting to http since the daemon listens on plain HTTP) and preserve the port from the Host header, which was silently dropped before. Also refuse to forward requests that resolve back to the daemon's own listen address (a base-URL override without a provider prefix would otherwise loop through the proxy until the loop guard trips), returning a clear error instead.
rohansx
self-requested a review
August 13, 2026 18:25
rohansx
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve scheme
Host-header fallback routing hardcoded https for every upstream URL, so any plain-http request to the proxy failed with "io error: error sending request for url (https://...)". Resolve the upstream with the scheme the client actually used (URI scheme, defaulting to http since the daemon listens on plain HTTP) and preserve the port from the Host header, which was silently dropped before.
Refuse self-forwarding
Refuse to forward requests that resolve back to the daemon's own listen address (a base-URL override without a provider prefix would otherwise loop through the proxy until the loop guard trips), returning a clear error instead.
Fixes #3