Copy the mpt-crypto static archive and link manifest, not the shared object - #94
Merged
Merged
Conversation
manasip-prog
force-pushed
the
manasip/mpt-crypto-static-archive
branch
from
September 8, 2026 14:40
211d955 to
5f485b1
Compare
bthomee
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build workload imagehas not succeeded since #92 movedXRPL_PY_REFfrompre-3.3-release-grouptomain. It was masked until now because every run since was failing earlier — first on the deletedconfidential-mptbranch, then on expired credentials.xrpl-py
mainchanged how the cffi extension links.build_mpt_crypto.pynow passeslibs/linux/libmpt-crypto.aas anextra_objectand reads the system libraries to co-link frommpt-crypto-static.link-libs.txtbeside it, producing a self-contained.so.pre-3.3-release-grouploadedlibmpt-crypto.soat runtime instead. The setup script still copies only the.so, so the link has no archive to resolve against:Both files ship in the same
mpt-crypto-natives-<version>.tar.gzalready being downloaded, so this copies them instead of the.so.Observed on ripple/rippled-antithesis run 33932187051, where
build xrpldpasses andbuild workload imagefails on the link.🤖 Generated with Claude Code