Merge getTable and Lookup function in information schema#9640
Conversation
|
@codex : review |
NamanMahor
added
Area:Connectors
Size:L
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1939316bd7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else { | ||
| return nil, err | ||
| } | ||
| } else if pbType.Code == runtimev1.Type_CODE_UNSPECIFIED { |
There was a problem hiding this comment.
This code handling is gone now. If it returns errUnsupportedType it will simply fail the Lookup call.
Need to check other drivers as well.
There was a problem hiding this comment.
I see you handled it in GetTable. Does it required handling in OLAPGetTable as well ?
Are there any other internal callers that will fail because of this ?
There was a problem hiding this comment.
all other Lookup caller are same as before there is no change in lookup method or it's caller. only get table is new caller of it. Also i m going to remove OLAPGetTable in upcoming pr.
2 participants
Merge GetTable and Lookup function in information schema
Checklist: