fix: hide Discord link in embedded canvas pivot tables#9639
Open
rohithreddykota wants to merge 1 commit into
Open
fix: hide Discord link in embedded canvas pivot tables#9639rohithreddykota wants to merge 1 commit into
rohithreddykota wants to merge 1 commit into
Conversation
CanvasPivotRenderer rendered PivotEmpty without passing isEmbedded, so it defaulted to false and the Discord/docs links still showed in embedded canvas pivot components. Pass EmbedStore.isEmbedded(), matching the explore path fixed in #9135.
nishantmonu51
added
Type:Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hide the Discord/docs links in embedded canvas pivot tables.
PivotEmpty'sisEmbeddedprop, which only the explore path threaded through.CanvasPivotRenderernever passed it, so Discord still showed in embedded canvas pivot components.isEmbedded={EmbedStore.isEmbedded()}fromCanvasPivotRenderer, matching the explore path.Checklist:
Developed in collaboration with Claude Code