Repository navigation
Conversation
🔍 Skill Validation (Advisory — does not block merge)
|
- add tests for create-dev-to-main-pr.yml and tweak for issues found along the way - add tests for pr-branch-check.yml and tweak for issues found along the way - add creation of workflow to bump quickstart version to rh-qs-test-suite and add assoccciated tests Signed-off-by: Michael Dawson <midawson@redhat.com>
mhdawson
force-pushed
the
rh-qs-test-suite-next2
branch
from
November 16, 2026 16:19
82bb8f1 to
13d6485
Compare
mhdawson
marked this pull request as ready for review
November 16, 2026 16:20
Member
Author
|
Rebased, ready for review |
🔍 Skill Validation (Advisory — does not block merge)
|
YosiElias
approved these changes
Nov 17, 2026
YosiElias
left a comment
Collaborator
There was a problem hiding this comment.
Besides the two small comments below, LGTM 🚀
Collaborator
There was a problem hiding this comment.
Is -bump-r intentional, or should it be -bump-pr?
| runs-on: ubuntu-latest | ||
| steps: | ||
| - run: | | ||
| PR_SOURCE_BRANCH="${{ github.event.pull_request.head.ref }}" |
Collaborator
There was a problem hiding this comment.
The branch name is inserted directly into the bash script. A valid branch name such as dev-$(id) runs id before the fork check rejects the PR. Please consider pass head.ref through the step’s env and compare the variable as text. The same fix should also be applied to core/skills/rh-qs-test-suite/references/workflow-skeletons.md:167.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft since has ealier comments that have not yet landed, will rebased once those land.