Skip to content

feat: add more tests for rh-qs-test-suite - #51

Open
mhdawson wants to merge 1 commit into
rh-ai-quickstart:mainfrom
mhdawson:rh-qs-test-suite-next2
Open

mhdawson wants to merge 1 commit into
rh-ai-quickstart:mainfrom
mhdawson:rh-qs-test-suite-next2

Conversation

@mhdawson

Copy link
Copy Markdown
Member
  • add tests for create-dev-to-main-pr.yml and tweak for issues found along the way
  • add tests for pr-branch-check.yml and tweak for issues found along the way
  • add creation of workflow to bump quickstart version to rh-qs-test-suite and add assocciated tests

Draft since has ealier comments that have not yet landed, will rebased once those land.

@github-actions

Copy link
Copy Markdown

🔍 Skill Validation (Advisory — does not block merge)

⚠️ Warnings

  • unknown directory: subagents/ (contains 3 files) — agents using the standard skill structure won't discover these files; should this be assets/?

📋 Full report

- add tests for create-dev-to-main-pr.yml and tweak for issues found along the way
- add tests for pr-branch-check.yml and tweak for issues found along the way
- add creation of workflow to bump quickstart version to rh-qs-test-suite and add assoccciated tests

Signed-off-by: Michael Dawson <midawson@redhat.com>
@mhdawson
mhdawson force-pushed the rh-qs-test-suite-next2 branch from 82bb8f1 to 13d6485 Compare November 16, 2026 16:19
@mhdawson
mhdawson marked this pull request as ready for review November 16, 2026 16:20
@mhdawson

Copy link
Copy Markdown
Member Author

Rebased, ready for review

@github-actions

Copy link
Copy Markdown

🔍 Skill Validation (Advisory — does not block merge)

⚠️ Warnings

  • unknown directory: subagents/ (contains 3 files) — agents using the standard skill structure won't discover these files; should this be assets/?

📋 Full report

@YosiElias YosiElias left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the two small comments below, LGTM 🚀

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is -bump-r intentional, or should it be -bump-pr?

runs-on: ubuntu-latest
steps:
- run: |
PR_SOURCE_BRANCH="${{ github.event.pull_request.head.ref }}"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch name is inserted directly into the bash script. A valid branch name such as dev-$(id) runs id before the fork check rejects the PR. Please consider pass head.ref through the step’s env and compare the variable as text. The same fix should also be applied to core/skills/rh-qs-test-suite/references/workflow-skeletons.md:167.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants