Skip to content

feat: more tests and fixes for rh-qs-test-suite - #50

Merged
mhdawson merged 2 commits into
rh-ai-quickstart:mainfrom
mhdawson:rh-qs-test-suite-next
Nov 16, 2026
Merged

mhdawson merged 2 commits into
rh-ai-quickstart:mainfrom
mhdawson:rh-qs-test-suite-next

Conversation

@mhdawson

Copy link
Copy Markdown
Member
  • additional tests for rh-qs-test-suite focussed on creation of core pr test
    workflow
  • fixes found while building/running tests
  • fixes found when testing on 2 quickstarts

@mhdawson

Copy link
Copy Markdown
Member Author

Draft since it includes some commits for earlier PR that has not yet been landed.

@github-actions

Copy link
Copy Markdown

🔍 Skill Validation (Advisory — does not block merge)

⚠️ Warnings

  • unknown directory: subagents/ (contains 3 files) — agents using the standard skill structure won't discover these files; should this be assets/?

📋 Full report

@github-actions

Copy link
Copy Markdown

🔍 Skill Validation (Advisory — does not block merge)

⚠️ Warnings

  • unknown directory: subagents/ (contains 3 files) — agents using the standard skill structure won't discover these files; should this be assets/?

📋 Full report

- additional tests for rh-qs-test-suite focussed on creation of core pr test
  workflow
- fixes found while building/running tests
- fixes found when testing on 2 quickstartttts
Signed-off-by: Michael Dawson <midawson@redhat.com>
@mhdawson
mhdawson force-pushed the rh-qs-test-suite-next branch from e6228a3 to 24b69ba Compare November 16, 2026 14:28
@mhdawson
mhdawson marked this pull request as ready for review November 16, 2026 14:28
@github-actions

Copy link
Copy Markdown

🔍 Skill Validation (Advisory — does not block merge)

⚠️ Warnings

  • unknown directory: subagents/ (contains 3 files) — agents using the standard skill structure won't discover these files; should this be assets/?

📋 Full report

@mhdawson

Copy link
Copy Markdown
Member Author

Rebased after landing earlier PR, ready.

@YosiElias YosiElias left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mhdawson
mhdawson merged commit a081ee2 into rh-ai-quickstart:main Nov 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants