Skip to content

feat: add tests for more or rh-qs-test-suite - #49

Merged
mhdawson merged 2 commits into
rh-ai-quickstart:mainfrom
mhdawson:rh-qs-test-suite-more
Nov 16, 2026
Merged

mhdawson merged 2 commits into
rh-ai-quickstart:mainfrom
mhdawson:rh-qs-test-suite-more

Conversation

@mhdawson

@mhdawson mhdawson commented Oct 26, 2026 •

Copy link
Copy Markdown
Member
  • add tests for image build and push workflow generation
  • tweaks to fix issues found along the way
  • extentions to cover uses cases not handled originally in quickstarts tested on
  • fix: minor fixes found fro GLM 5.3/codex testing
    • tweak nightly-test-prompt in rh-qs-test-suite to assume main if no git info
  • adjust expected location of pipeline files due to changes in quickstart factory

- tweak nightly-test-prompt in rh-qs-test-suite to assume main if no git info
- adjust expected location of pipeline files due to changes in quickstart factory

Signed-off-by: Michael Dawson <midawson@redhat.com>
- add tests for build and build workflow generation
- tweaks to fix issues found along the way

Signed-off-by: Michael Dawson <midawson@redhat.com>
@github-actions

Copy link
Copy Markdown

🔍 Skill Validation (Advisory — does not block merge)

⚠️ Warnings

  • unknown directory: subagents/ (contains 3 files) — agents using the standard skill structure won't discover these files; should this be assets/?

📋 Full report

@mhdawson
mhdawson marked this pull request as ready for review October 26, 2026 22:11
@mhdawson

Copy link
Copy Markdown
Member Author

Should we update the review action for this:

Structure
unknown directory: subagents/ (contains 3 files) — agents using the standard skill structure won't discover these files; should this be assets/?

Or are the subagents actually in the wrong place?

@mhdawson mhdawson mentioned this pull request Oct 26, 2026
@mhdawson
mhdawson requested a review from YosiElias October 27, 2026 22:43

@YosiElias YosiElias left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @mhdawson !

@YosiElias

Copy link
Copy Markdown
Collaborator

should this be assets/?
Or are the subagents actually in the wrong place?

I think subagents/ is a justified extension to the standard structure because it only contains prompts, not automatically discovered subagents. Each prompt is called explicitly at a specific step within its skill, so automatic discovery isn’t needed (and would use extra tokens for their descriptions). Happy to consider another approach if you think there’s a better fit.

@mhdawson
mhdawson merged commit cf00b52 into rh-ai-quickstart:main Nov 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants