Skip to content

Minio convert - #45

Merged
johnson2500 merged 6 commits into
mainfrom
minio-convert
Oct 7, 2026
Merged

johnson2500 merged 6 commits into
mainfrom
minio-convert

Conversation

@johnson2500

Copy link
Copy Markdown
Collaborator

Description:

  • Convert an existing AI Quickstart from MinIO (ai-architecture-charts minio
    subchart or hand-rolled templates) to the shared aws-compatible-storage chart
    (S4-backed) from ai-architecture-charts. Removes MinIO wiring, adds the
    aws-compatible-storage Helm dependency, updates app endpoints/credentials, and
    rewrites MinIO mentions in docs. Use when migrating a quickstart off MinIO
    onto S4 / aws-compatible-storage.

@github-actions

Copy link
Copy Markdown

🔍 Skill Validation (Advisory — does not block merge)

❌ Errors

⚠️ Warnings

  • SKILL.md body is 6782 tokens (spec recommends < 5000)

📋 Full report

@github-actions

Copy link
Copy Markdown

🔍 Skill Validation (Advisory — does not block merge)

❌ Errors

  • internal link escapes skill directory: ../../../docs/foundation/validation-skill-template.md
  • internal link escapes skill directory: ../rh-qs-deploy/references/helm-minio.md

⚠️ Warnings

  • SKILL.md body is 6782 tokens (spec recommends < 5000)

📋 Full report

@YosiElias YosiElias left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnson2500 ! Tried this out and it works great, super helpful 🚀
*I left two suggestions

4. Rewires consumers to the S3 API (`:7480`) and `{fullname}-credentials`
5. Adds a **regular** bucket bootstrap Job in the **parent** chart (UBI Python + boto3 — no `minio/mc`, no Docker Hub)
6. Updates READMEs, env examples, scripts, diagrams (MinIO → aws-compatible-storage / S4)
7. Verifies with `helm lint` / `helm template` / chart unit tests; recommend **`rh-qs-verify-deploy`**

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: What if we point to rh-qs-debug-and-deploy instead? It handles deploy, test, AND debug/fix if there's a conversion gap (it caught an edge case for me on Loki's bundled MinIO)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that Idea. Let me add it.

Co-authored-by: Yossi Elias <73485442+YosiElias@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

🔍 Skill Validation (Advisory — does not block merge)

❌ Errors

  • internal link escapes skill directory: ../../../docs/foundation/validation-skill-template.md
  • internal link escapes skill directory: ../rh-qs-deploy/references/helm-minio.md

⚠️ Warnings

  • SKILL.md body is 6796 tokens (spec recommends < 5000)

📋 Full report

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

🔍 Skill Validation (Advisory — does not block merge)

❌ Errors

  • internal link escapes skill directory: ../../../docs/foundation/validation-skill-template.md
  • internal link escapes skill directory: ../rh-qs-deploy/references/helm-minio.md

⚠️ Warnings

  • SKILL.md body is 6878 tokens (spec recommends < 5000)

📋 Full report

@johnson2500
johnson2500 merged commit f4124e1 into main Oct 7, 2026
3 checks passed
@johnson2500
johnson2500 deleted the minio-convert branch October 7, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants