Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/pca-ai-serving/templates/llminferenceservice.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ spec:
route: {}
gateway:
refs:
- name: {{ .Values.gatewayName | default "llm-d-gateway" }}
namespace: {{ .Values.gatewayNamespace | default .Values.namespace }}
- name: {{ (.Values.maas).gatewayName | default "maas-default-gateway" }}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The router gateway always becomes maas-default-gateway, even when nativeAuth is false. The controller then publishes /{namespace}/{name}/... on the public gateway. Those paths are not covered by the front-door API-key filter, and the gateway AuthPolicy is fail-open. gatewayName (llm-d-gateway) is ignored here, so the controller route and the llm-d catch-all diverge.

namespace: {{ (.Values.maas).gatewayNamespace | default "openshift-ingress" }}
template:
volumes:
- name: kserve-provision-location
Expand Down
3 changes: 2 additions & 1 deletion charts/pca-ai-serving/templates/maas-authz-envoyfilter.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{{- $maas := .Values.maas | default dict }}
{{- if $maas.enabled | default true }}
{{- if and ($maas.enabled | default true) (not ($maas.nativeAuth | default false)) }}
{{/* Skip custom PCA auth when maas.nativeAuth=true (RHOAI 3.5 MaaS handles auth natively). */}}
{{- $gwNs := $maas.gatewayNamespace | default "openshift-ingress" }}
{{- $gwName := $maas.gatewayName | default "maas-default-gateway" }}
{{- $public := include "pca-ai-serving.maasPublicHostname" . }}
Expand Down
6 changes: 3 additions & 3 deletions charts/pca-ai-serving/templates/maas-crs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ spec:
modelRef:
kind: LLMInferenceService
name: {{ include "pca-ai-serving.model.name" . }}
{{- if $maas.hostname }}
{{- if and (not ($maas.nativeAuth | default false)) $maas.hostname }}
endpointOverride: https://{{ $maas.hostname }}/v1
{{- else }}
{{- else if not ($maas.nativeAuth | default false) }}
endpointOverride: https://{{ include "pca-ai-serving.maasGatewayService" . }}/v1
{{- end }}
---
Expand All @@ -38,7 +38,7 @@ spec:
window: "1h"
- limit: {{ ($maas.tokenLimit).daily | default 50000000 }}
window: "24h"
priority: 10
priority: {{ $maas.subscriptionPriority | default 10 }}
---
apiVersion: maas.opendatahub.io/v1alpha1
kind: MaaSAuthPolicy
Expand Down
3 changes: 2 additions & 1 deletion charts/pca-ai-serving/templates/maas-httproute.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{{- $maas := .Values.maas | default dict }}
{{- if $maas.enabled | default true }}
{{- if and ($maas.enabled | default true) (not ($maas.nativeAuth | default false)) }}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nativeAuth: true deletes the whole front door: /v1, /local/v1, chat→guardrails, the API-key AuthPolicy, and the token-limit override. DevSpaces call /v1 and /local/v1. RHOAI’s routes are /llm/<model>/v1.

{{/* Skip custom PCA HTTPRoute when maas.nativeAuth=true — RHOAI creates routes on maas-default-gateway. */}}
{{- $llmdSvc := include "pca-ai-serving.llmdGatewayService" . }}
{{/* MaaS Envoy talks HTTP to backends. Use llm-d :80 (HTTP listener), not :443. */}}
{{- $llmdPort := 80 }}
Expand Down
3 changes: 2 additions & 1 deletion charts/pca-ai-serving/templates/maas-models-envoyfilter.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{{- $maas := .Values.maas | default dict }}
{{- if $maas.enabled | default true }}
{{- if and ($maas.enabled | default true) (not ($maas.nativeAuth | default false)) }}
{{/* Skip custom PCA EnvoyFilter when maas.nativeAuth=true. */}}
{{- $gwNs := $maas.gatewayNamespace | default "openshift-ingress" }}
{{- $gwName := $maas.gatewayName | default "maas-default-gateway" }}
{{- $public := include "pca-ai-serving.maasPublicHostname" . }}
Expand Down