Skip to content

Faerun produces invalid tree coordinates in create_python_data() #10

Description

@grayver

Hello! Thanks for all your work and Faerun library!

I've discovered that Faerun.create_data() which produces JS output and Faerun.create_python_data() which produces Python output have different tree coordinates. It seems to be there is a problem with scale, because when you open saved *.faerun file in the hosted mode - the tree has different scale comparing to scatter plot.

I've investigated it a little bit and found the cause - in create_python_data() method the same variable s is used for the scale:

s = self.scale

and for the iterator:

for s in range(len(data[mapping["c"]])):

P.S. also there is a problem generating HTML output on Windows when you have unicode characters in your labels. This seems to be output file encoding issue.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions