Repository navigation
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
jeremi
marked this pull request as ready for review
July 28, 2026 17:44
jeremi
enabled auto-merge (squash)
July 28, 2026 17:45
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 771ffabc03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Recovery run 30383767143 reached the prewrite candidate verifier and failed because the sealed v0.15.0 receipt correctly binds four payload artifacts, while the publication workflow separately required exactly five. The receipt schema already derives the exact expected payload set from whether repeatability comparisons were performed, so the workflow count was duplicated and stale.
Impact
The release path no longer needs an allowlist or hardcoded count for auxiliary artifacts produced by the same candidate attempt. Extra reports cannot be promoted unless the sealed receipt names them and binds their artifact IDs and archive hashes. Mandatory candidate artifacts, receipt validation, attestations, scans, provenance, and no-rebuild promotion remain unchanged.
Verification
python3 -m unittest release/scripts/test_release_candidate.py(20 passed)python3 -m unittest release/scripts/test_registry_release.py(92 passed)python3 release/scripts/check-gates-inventory.py(168 gates)git diff --checkSecurity review note
This changes release provenance tooling. The preserved invariant is that only artifacts explicitly bound by the sealed candidate receipt, with exact IDs and SHA-256 archive hashes, are downloaded and promoted. Additional same-attempt artifacts may exist in metadata but are not trusted as release payloads.