Skip to content

feat: expose applicant review progress - #2655

Merged
jeremi merged 3 commits into
mainfrom
feat/proposal-review-progress-2653
Nov 12, 2026
Merged

jeremi merged 3 commits into
mainfrom
feat/proposal-review-progress-2653

Conversation

@jeremi

@jeremi jeremi commented Nov 12, 2026

Copy link
Copy Markdown
Member

Closes #2653.

Changes

  • Let Casework policies publish an optional progress code for each active review stage. The accepted policy digest covers the code.
  • Add include=progress to BReg Proposal review status and expose it in the Rust, Node.js, and Python clients. The paired example shows a stage transition and a fresh round after resubmission.
  • Document Coordinator composition. Its follow waits on the ordinary Proposal read and remains pending when an approved Proposal still needs manual Apply.

Security review

BReg checks the current caller-owned status grant before contacting Casework. A single bounded lookup runs outside the database transaction and uses BReg’s producer credential. BReg verifies the exact accepted binding, rechecks current visibility and the live review round, and audits release of the configured code. Failed lookups and changed rounds return freshly authorized local status with progress omitted.

Before enabling codes, upgrade Casework clients that decode complete policy or task-context closures and update any strict policy pin for future submissions. Refresh the imported Coordinator Action contract if the pin changes the Action revision. Use a separate Casework producer identity for standalone Coordinator reviews.

Verification

  • Live BReg and Casework HTTP routes on PostgreSQL covered stage changes, cross-applicant refusal, fallback, terminal status, and return and resubmission.
  • BReg PostgreSQL security regressions covered withdrawal during lookup and terminal audit failure.
  • Separate Coordinator adapter and PostgreSQL wait suites covered Proposal-only follow through approval and application.
  • Rust client tests, Node.js tests and types, Python client tests, BReg contract gates, Casework schema gates, formatting, and focused Clippy passed.

Refs #2653

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T04:54:06.380878Z 9cede60 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

…posal-review-progress-2653

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
@jeremi
jeremi added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 2756946 Nov 12, 2026
72 checks passed
@jeremi
jeremi deleted the feat/proposal-review-progress-2653 branch November 12, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BReg and Casework: expose applicant-visible progress for a Proposal under review

1 participant