Repository navigation
Improve first-run integration for BReg, Casework and Render - #2652
Merged
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$localClientSubjectinclaims.principalandclaims.directClaims.sub. Both assertions resolve from the selected client in the private captured fixture.Closes #2651
Evidence
cargo test --locked -p registry-bregctl --lib dev::passed 317 tests with 4 existing tests ignored. The newinstalled_dev_rehearses_subject_bound_rows_with_two_local_clientstest incargo test --locked -p registry-bregctl --test dev_lifecyclepassed when explicitly enabled, using source-built BReg and the pinned PostgreSQL and ThunderID images. It checked that the owner saw the row, the second client received an empty list, and authored fixture bytes stayed intact.cargo test --locked -p registry-casework --features postgres-test --test breg_review_journeypassed all four tests against disposable PostgreSQL. The canonical template and Administrator binding checks passed. A reader run ofbregctl examples reviewwith source-built CLIs executed the installedapprove-task.shand read the retained receipt. The Casework OpenAPI and product checks passed.cargo test --locked -p registry-render --lib worker::testspassed, covering a premature exit code, signal, bounded wait, and stderr canary. Thegolden,scaffold, andservetest binaries passed on macOS with Render's default log filter. The built CLI rejectedexampleTitleand compiled a strict PDF withexample_title. Linux CI will exercise the configured cap with a synthetic worker exit. The original Rosetta scenario remains unverified.The first Linux run passed the exit status, signal, cap, and stderr redaction regression. A separate stand-in failed at process launch. The fixture now invokes
/bin/shexplicitly and includes the OS error in a failing assertion. All seven focused worker tests passed after the correction on macOS.Every commit carries a
Signed-off-bytrailer.