Repository navigation
fix(render): declare seal assurance once per runtime, matching Evidence - #2594
Merged
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9f854694e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ntime security member The schema accepted null for assuranceProfile and the config conventions registry still named the removed per-seal trust pointer. Regenerate the runtime schema and identifier catalog. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Render seals declared their assurance per seal (
trust: test-only | production), while Evidence declares it once per runtime (assuranceProfile). Two names for the same rule make deployments harder to read and review. This PR gives Render Evidence's member and values, so one runtime-wide setting decides how every seal signs.Seals are unreleased (they landed after v0.45.0), so this renames the configuration before anyone depends on it.
What changes
assuranceProfile: local | productionin the Render runtime file. It is required whensigning.sealsdeclares a seal; a runtime with no seals loads without it.productionseals sign only throughtransit;localseals sign only with alocal-jwkkey file and are test seals. The other signer is refused per seal asrender.runtime.signer-assurance-mismatchat/signing/seals/<id>/signer/type(this replacesrender.runtime.seal-signer-assurance-mismatch).trustmember is gone; a leftover one is refused asconfig.unknown-key.evidence-gradeis refused asconfig.unknown-variant.signing.testOnly, theX-Registry-Seal-Test-Onlyheader,/ready, the audit and the startup warning still mark test seals, now derived fromlocal.compile --preview-seal test-only|productionkeeps its values (its value name is nowKIND).Migration
Checks
cargo fmt --checkcargo clippy -p registry-render --all-targets --features schema -- -D warningscargo test -p registry-render --features schemacargo test -p registry-cli-docstest_validate_seal.pygenerate,check:cli-reference,check:evidence-links,check:evidence-anchors,check:relative-links,check:content,check:style,check:openapi,check:config-vocabulary,check:markdown,check:tutorial:render:dry-run,check:tutorial:documents:dry-runNot run locally: the full docs site build and built-site checks.