Repository navigation
fix: keep Coordinator Functions inside their size limits without curry - #2589
Merged
Merged
Conversation
Rhai does not count data curried into a function pointer against the size limits, so the pure profile disables `curry`, as the deterministic base already does for every other Rhai script. The callable set is part of the interpreter ABI, which moves to v3. Check names `curry` and suggests passing the value as an argument instead of a generic syntax error, and a refusal in a source shared by several Functions is reported once. BREAKING CHANGE: definitions frozen under interpreter ABI v2 are refused with `definition.abi`; check and promote projects again. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coordinator's pure Function profile disables
curry, matching the deterministic Rhai base every other product script runs on since #2575. Rhai does not count data curried into a function pointer against the profile's size limits.Changes
curryis a disabled symbol in the pure profile and is no longer listed bycoordinatorctl explain functions.v2tov3, because the callable set is part of what a frozen definition means (SECURITY-MODEL, COORDINATOR-INV-12).coordinatorctl checknow says "function source usescurry, which Coordinator Functions do not offer" and suggests passing the value as an argument. Before, the parser reported "Expecting name of a property". A compile refusal in afunctions.rhaishared by several Functions is reported once instead of once per Function, as unknown-call findings already were.Upgrade impact
Every definition frozen by 0.45.0 records ABI
v2and is refused withdefinition.abi, whether or not it usescurry. As with the v1 to v2 change in 0.45.0: settle runs with the 0.45.0 binaries, then check and promote the project again. No maintained example or Studio-generated Function usescurry.Verification
cargo test --locked --no-fail-fast -p registry-coordinator: 662 passed, 0 failed (macOS, no PostgreSQL URL set, sopostgres-testtargets are left to CI).cargo clippy --locked -p registry-coordinator --all-targets -- -D warnings,cargo fmt --check: clean.products/coordinator/scripts/check-schemas.sh: passed. Coordinator script unit tests: 70 OK. Dependency direction check: passed.coordinatorctl checkon thedecision-follow-upexample passes unchanged; with acurrycall added, it reports the single finding above at its line and column.