Skip to content

Update test#7446

Closed
jedelbo wants to merge 5 commits into
masterfrom
je/collection-updating
Closed

Update test#7446
jedelbo wants to merge 5 commits into
masterfrom
je/collection-updating

Conversation

@jedelbo

@jedelbo jedelbo commented Mar 11, 2024

Copy link
Copy Markdown
Contributor

What, How & Why?

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

tgoyne and others added 5 commits March 8, 2024 09:07
We only need the very next path element, not the entire remaining path.
…cated code

m_run_time_point was read on the target thread while being written on the
worker thread without any locking involved.
Giving Obj a virtual base class turns out to have a meaningful performance
impact.
@coveralls-official

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build jorgen.edelbo_137

Details

  • 34 of 34 (100.0%) changed or added relevant lines in 1 file are covered.
  • 19 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.9%) to 90.929%

Files with Coverage Reduction New Missed Lines %
src/realm/sync/instruction_replication.cpp 1 90.52%
test/fuzz_group.cpp 2 52.12%
src/realm/alloc_slab.cpp 5 92.93%
src/realm/sync/noinst/client_impl_base.cpp 5 85.34%
src/realm/index_string.cpp 6 87.49%
Totals Coverage Status
Change from base Build thomas.goyne_223: 0.9%
Covered Lines: 238527
Relevant Lines: 262321

💛 - Coveralls

Base automatically changed from tg/obj-perf to master March 13, 2024 04:51
@tgoyne

tgoyne commented Mar 13, 2024

Copy link
Copy Markdown
Member

Added this test plus some more to #7402.

@tgoyne tgoyne closed this Mar 13, 2024
@tgoyne tgoyne deleted the je/collection-updating branch March 13, 2024 04:51
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants