Skip to content

fix(mdx): collapse blank lines between JSX table elements on serialize #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jesseyowell wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix(mdx): collapse blank lines between JSX table elements on serialize #1444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions __tests__/compilers/compatability.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,19 +392,16 @@ ${JSON.stringify(
<th style={{ textAlign: "left" }}>
Term
</th>

<th style={{ textAlign: "left" }}>
Definition
</th>
</tr>
</thead>

<tbody>
<tr>
<td style={{ textAlign: "left" }}>
Events
</td>

<td style={{ textAlign: "left" }}>
Pseudo-list:\\
● One\\
Expand Down Expand Up @@ -462,19 +459,16 @@ ${JSON.stringify(
<th style={{ textAlign: "left" }}>
Field
</th>

<th style={{ textAlign: "left" }}>
Description
</th>
</tr>
</thead>

<tbody>
<tr>
<td style={{ textAlign: "left" }}>
orderby
</td>

<td style={{ textAlign: "left" }}>
\`\`\`
{
Expand Down
18 changes: 0 additions & 18 deletions __tests__/compilers/tables.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,21 +66,18 @@ describe('table compiler', () => {
th 1
🦉
</th>

<th style={{ textAlign: "center" }}>
th 2
🦉
</th>
</tr>
</thead>

<tbody>
<tr>
<td style={{ textAlign: "center" }}>
cell 1
🦉
</td>

<td style={{ textAlign: "center" }}>
cell 2
🦉
Expand Down Expand Up @@ -112,21 +109,18 @@ describe('table compiler', () => {
th 1
🦉
</th>

<th style={{ textAlign: "center" }}>
th 2
🦉
</th>
</tr>
</thead>

<tbody>
<tr>
<td style={{ textAlign: "center" }}>
cell 1
🦉
</td>

<td style={{ textAlign: "center" }}>
cell 2
🦉
Expand Down Expand Up @@ -159,21 +153,18 @@ describe('table compiler', () => {
th 1
🦉
</th>

<th>
th 2
🦉
</th>
</tr>
</thead>

<tbody>
<tr>
<td>
cell 1
🦉
</td>

<td>
cell 2
🦉
Expand Down Expand Up @@ -213,19 +204,16 @@ describe('table compiler', () => {
* 2
* 3
</th>

<th style={{ textAlign: "center" }}>
th 2
</th>
</tr>
</thead>

<tbody>
<tr>
<td style={{ textAlign: "center" }}>
cell 1
</td>

<td style={{ textAlign: "center" }}>
cell 2
</td>
Expand Down Expand Up @@ -312,19 +300,16 @@ describe('table compiler', () => {
<th>
* list
</th>

<th>
th 2
</th>
</tr>
</thead>

<tbody>
<tr>
<td>
cell 1
</td>

<td>
cell 2
</td>
Expand Down Expand Up @@ -384,19 +369,16 @@ describe('table compiler', () => {
force
jsx
</th>

<th style={{ textAlign: "left" }}>

</th>
</tr>
</thead>

<tbody>
<tr>
<td style={{ textAlign: "left" }}>
\`foo | bar\`
</td>

<td style={{ textAlign: "left" }}>

</td>
Expand Down
3 changes: 0 additions & 3 deletions __tests__/migration/link-reference.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,19 +76,16 @@ hello there [something]
<th>
Response
</th>

<th>

</th>
</tr>
</thead>

<tbody>
<tr>
<td>
\\{'Message': 'There are validation errors', 'Errors': ['ConsumerDetails: The ExternalId or CustomerID must have a value.']}
</td>

<td>

</td>
Expand Down
32 changes: 0 additions & 32 deletions __tests__/migration/tables.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,19 +45,16 @@ ${JSON.stringify(
<th style={{ textAlign: "left" }}>
Field
</th>

<th style={{ textAlign: "left" }}>
Description
</th>
</tr>
</thead>

<tbody>
<tr>
<td style={{ textAlign: "left" }}>
orderby
</td>

<td style={{ textAlign: "left" }}>
\`\`\`
{
Expand Down Expand Up @@ -104,30 +101,25 @@ ${JSON.stringify(
<th style={{ textAlign: "left" }}>
Field
</th>

<th style={{ textAlign: "left" }}>
Description
</th>
</tr>
</thead>

<tbody>
<tr>
<td style={{ textAlign: "left" }}>
numbered lists
</td>

<td style={{ textAlign: "left" }}>
1. numbered lists
2. are supported too
</td>
</tr>

<tr>
<td style={{ textAlign: "left" }}>
loose lists
</td>

<td style={{ textAlign: "left" }}>
* loose lists

Expand Down Expand Up @@ -173,19 +165,16 @@ ${JSON.stringify(
<th style={{ textAlign: "left" }}>
Field
</th>

<th style={{ textAlign: "left" }}>
Description
</th>
</tr>
</thead>

<tbody>
<tr>
<td style={{ textAlign: "left" }}>
reproduction
</td>

<td style={{ textAlign: "left" }}>
Oh no

Expand All @@ -194,12 +183,10 @@ ${JSON.stringify(
* Im so sorry
</td>
</tr>

<tr>
<td style={{ textAlign: "left" }}>
reproduction 2
</td>

<td style={{ textAlign: "left" }}>
Oh no

Expand All @@ -208,12 +195,10 @@ ${JSON.stringify(
* Im so sorry
</td>
</tr>

<tr>
<td style={{ textAlign: "left" }}>
reproduction 3
</td>

<td style={{ textAlign: "left" }}>
Oh no

Expand Down Expand Up @@ -245,7 +230,6 @@ ${JSON.stringify(
</th>
</tr>
</thead>

<tbody>
<tr>
<td>
Expand Down Expand Up @@ -289,29 +273,24 @@ ${JSON.stringify(
<th style={{ textAlign: "left" }}>
**Shortcut Name**
</th>

<th style={{ textAlign: "left" }}>
**WindowsOS**
</th>
</tr>
</thead>

<tbody>
<tr>
<td style={{ textAlign: "left" }}>
**Select None**
</td>

<td style={{ textAlign: "left" }}>
\`ESC\`
</td>
</tr>

<tr>
<td style={{ textAlign: "left" }}>
**Select All**
</td>

<td style={{ textAlign: "left" }}>
\`CTRL\` + \`A\`
</td>
Expand Down Expand Up @@ -351,19 +330,16 @@ ${JSON.stringify(
<th>
Field
</th>

<th>
Description
</th>
</tr>
</thead>

<tbody>
<tr>
<td>
reproduction
</td>

<td>
Oh no

Expand Down Expand Up @@ -410,31 +386,26 @@ ${JSON.stringify(
<th style={{ textAlign: "left" }}>
**Shortcut Name**
</th>

<th style={{ textAlign: "left" }}>
**WindowsOS**
</th>

<th style={{ textAlign: "left" }}>
*Apple - macOS*
</th>
</tr>
</thead>

<tbody>
<tr>
<td style={{ textAlign: "left" }}>
*Cut selection*
</td>

<td style={{ textAlign: "left" }}>
**also**

*no!*

**no no no**
</td>

<td style={{ textAlign: "left" }}>
!BAD
</td>
Expand Down Expand Up @@ -474,19 +445,16 @@ ${JSON.stringify(
<th style={{ textAlign: "left" }}>
Action
</th>

<th style={{ textAlign: "left" }}>
Description
</th>
</tr>
</thead>

<tbody>
<tr>
<td style={{ textAlign: "left" }}>
Details
</td>

<td style={{ textAlign: "left" }}>
View additional details such as:\\
*Type*\\
Expand Down
Loading
Loading