fix: add optimistic concurrency to cancelOrderItem mutation - #6882
Closed
atharv-sys32 wants to merge 1 commit into
Closed
fix: add optimistic concurrency to cancelOrderItem mutation#6882atharv-sys32 wants to merge 1 commit into
atharv-sys32 wants to merge 1 commit into
Conversation
|
Parallel calls to cancelOrderItem for different fulfillment groups of the same order would race: each call reads the order, modifies its copy of the shipping groups, and writes the full updated shipping array back — overwriting changes from the concurrent call. Added optimistic concurrency control using updatedAt. If the order was modified by another request between read and write, findOneAndUpdate fails to match and throws an error, preventing silent data loss. Fixes reactioncommerce#6493 Signed-off-by: Atharv Pandey <atharvpandey245@gmail.com>
atharv-sys32
force-pushed
the
fix/reaction-6493-concurrent-cancel
branch
from
July 30, 2026 19:17
8419363 to
1816869
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel calls to cancelOrderItem for different fulfillment groups of the same order would race: each call reads the order, modifies its copy of the shipping groups, and writes the full updated shipping array back — overwriting changes from the concurrent call.
Added optimistic concurrency control using
updatedAt. If the order was modified by another request between read and write,findOneAndUpdatefails to match and throws an error, preventing silent data loss.Fixes #6493