Skip to content

Support vector<bool> when loading and saving json #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yoshikikanemoto merged 3 commits into from
Nov 19, 2025
+25 −1
Merged

Support vector<bool> when loading and saving json #1521

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cb35a8
[openravejson] Add support for saving and loading vector of bool.
Jul 10, 2025
24e6bbc
Bump version and update changelog.
Jul 10, 2025
d1294ba
Merge branch 'production' of https://github.com/rdiankov/openrave int…
yoshikikanemoto Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ set( CMAKE_ALLOW_LOOSE_LOOP_CONSTRUCTS TRUE )
# Define here the needed parameters
set (OPENRAVE_VERSION_MAJOR 0)
set (OPENRAVE_VERSION_MINOR 167)
set (OPENRAVE_VERSION_PATCH 6)
set (OPENRAVE_VERSION_PATCH 7)
set (OPENRAVE_VERSION ${OPENRAVE_VERSION_MAJOR}.${OPENRAVE_VERSION_MINOR}.${OPENRAVE_VERSION_PATCH})
set (OPENRAVE_SOVERSION ${OPENRAVE_VERSION_MAJOR}.${OPENRAVE_VERSION_MINOR})
message(STATUS "Compiling OpenRAVE Version ${OPENRAVE_VERSION}, soversion=${OPENRAVE_SOVERSION}")
Expand Down
5 changes: 5 additions & 0 deletions docs/source/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
ChangeLog
#########

Version 0.167.7
===============

- Add support for serialization and deserialization of std::vector<bool> for openravejson.

Version 0.167.6
===============

Expand Down
19 changes: 19 additions & 0 deletions include/openrave/openravejson.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,20 @@ inline void LoadJsonValue(const rapidjson::Value& v, bool& t) {
}
}

inline void LoadJsonValue(const rapidjson::Value& v, std::vector<bool>::reference t)

@rdiankov rdiankov Aug 21, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is std::vector<bool>::reference? is that std::vector<bool>&?

@cielavenir cielavenir Aug 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://en.cppreference.com/w/cpp/container/vector_bool.html , vector<bool>& is not applicable

{
if (v.IsInt())
t = v.GetInt();
else if (v.IsBool())
t = v.GetBool();
else if (v.IsString()) {
t = boost::lexical_cast<bool>(v.GetString());
}
else {
throw OPENRAVE_EXCEPTION_FORMAT("Cannot convert JSON type %s to Bool", GetJsonString(v), OpenRAVE::ORE_InvalidArguments);
}
}

template<class T>
inline void LoadJsonValue(const rapidjson::Value& v, OpenRAVE::RaveVector<T>& t) {
if(!v.IsArray() || (v.Size() != 3 && v.Size() != 4)) {
Expand Down Expand Up @@ -683,6 +697,11 @@ inline void SaveJsonValue(rapidjson::Value& v, bool t, rapidjson::Document::Allo
v.SetBool(t);
}

inline void SaveJsonValue(rapidjson::Value& v, const std::vector<bool>::reference t, rapidjson::Document::AllocatorType& alloc)
{
v.SetBool(t);
}

inline void SaveJsonValue(rapidjson::Value& v, double t, rapidjson::Document::AllocatorType& alloc) {
v.SetDouble(t);
}
Expand Down