Repository navigation
feat(shipping): verify S2-2 model buffers and compatibility gates - #582
Merged
Merged
Conversation
Only implementation changes from 1f50133baa82f3ed34b8864931138106a957f0507b0753b8d67eb073b34293b9 to bc378f688f9cd71b7a72b567f0718ac3d87d153fd8b246a15e6c17c927e24e5c: 297 to 303 files, six new model compatibility/native build/verified-byte helper files, twelve modified native loader/build/handoff files, no deletions. Decision surface, identity semantics, environment and runtime inputs are unchanged. Fresh --run-probe capture on source9fe51e6606e5a72e1cd52acbdf72913be7aebef8 after complete Release native build; publication_complete=true. Probe behavior digest matches outgoing publication but is freshly computed, not reused. Equality does not establish equivalence; state remains unproven with null proof. Independent Codex scratch review found no findings and recomputed all five axes, runtime inputs, recorder and current native build witnesses. Append-only archive preserves outgoing canonical exact bytes (SHA25641067d43a2c593ffade561ac3ba7a378dec4bc9c7d3b64612ece9c05c5b0a2a9). Candidate SHA25663f7ebebb38c758a54ef58a86d75c76b1c845758217a0d0f9d1ab0adc13d0c74. Attested staleness check passes. Coordinate-only stacked review, atomic delivery with principal S2-2 Draft. No independent main landing, Ready transition or merge authority.
raylei50653
marked this pull request as ready for review
October 11, 2026 09:19
This was referenced Oct 11, 2026
Closed
architecture(B): design a supported architecture with traceable diagrams and behavior contracts
#536
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Engine and head loading now uses the same SHA-256 verified memory buffers, closing their hash-to-reopen race. Manifest-mode Gate A matches one complete TRT/LibTorch/CUDA build target; Gate B rejects unsupported GPU SM before deserialization and checks exact TRT dtype/shape/name/order. N03 still loads by pathname, so S2-2 remains partial and the aggregate scope stays
hashed_before_load.Related scope: #549, #536 CC-536-01-02, ADR 028 D5, #550. Owner initially authorized a bounded Draft, then separately authorized Ready and merge at exact final head
1f428c740f045c7c627667d82e75d7ba97af79d8. It was merged by merge commit74f2f5cb1a3db8a1f42da48d533e3322f243d138on 2026-10-11; merge parents are the base and approved head, and merge tree equals the approved-head tree. Post-merge main CI 38128008627 (7/7) and C++ 38128008608 (1/1) succeeded at that exact merge SHA. Checkpoints: #549, #536, #550. S2-2 remains PARTIAL: engine/head buffer loading and compatibility gates implemented; N03 TOCTOU OPEN, aggregatehashed_before_load, qualified V5 UNRESOLVED.Exact coordinates and diff
f63c9da41f2aa034a76311ab14a62ab69ec8c540(main CI 38122766092: seven successful jobs).1f428c740f045c7c627667d82e75d7ba97af79d8.9fe51e6606e5a72e1cd52acbdf72913be7aebef8; later deltas are independently reviewed coordinate republication, evidence documentation and a whitespace-tolerant existing CMake-boundary test assertion. Binary/input/source hashes are recorded in the evidence document.79ffd5278c8226d104d67beb243a6f3111c78afe: independent scratch/promotion reviews have no findings; atomic ancestor delivery. GitHub automatically recognized docs(runtime): S2-2 coordinate-only atomic review #581 as merged into its feature-branch base after the local fast-forward ancestor push; no remote PR merge command or main landing occurred. That feature-branch recognition preceded the separately authorized feat(shipping): verify S2-2 model buffers and compatibility gates #582 main merge recorded above.Contract behavior
No schema, identity level, completion state, aggregate load verification, reader format, production allowlist or launcher policy is promoted. The existing immutable resolved bindings and DetectorPlan handoff are retained. The ordered manifest contract and only version-matched targets pass through an additional immutable plan value. LibTorch's CUDA qualifier is bound to the selected package config, headers, imported core libraries and literal core link paths; foreign origin cannot pass from base-version headers alone. TRT reads the full linked library build version through its no-device API; pinned SDK headers are a separate coordinate.
Successful diagnostics add per-artifact byte scopes: head/engine
loaded_buffer, operatorhashed_before_load. These do not promote the aggregate. Catchable Gate B failures retain Gate A identity, exit 2 and write failed/null byte scope. SIGKILL and auditor_exit(127)retain the existing uncatchablerunning/null semantics.Validation
1f428c740f045c7c627667d82e75d7ba97af79d8: no remaining actionable findings; reviewer independently reran corrected boundary assertion and verified40rawhashes/2binaries/346sourcebindings1f428c740f045c7c627667d82e75d7ba97af79d8: CI38126463978 (7/7) and C++38126463979 (1/1)Final local verification artifact
results/549_s2_2/final_local_delivery_verification.jsonSHA-25619393c70eb0b014e3a34d7ee03ccb42036d659f9201caff7f75bd49f1ff70b04; final full pre-push log SHA-2562a4168cdcfde489ee3d27c1fd8a56cca266f32300692ce1373def1301bb61834.Final-head review local artifact
results/549_s2_2/independent_final_review_1f428c74.mdSHA-2563703c6fde59327f5a4147492fc44ca3424d47a4572f5c85fbaac1da4fc43d5ae; check record SHA-2565c1c3f24c3fa3287c27721ad0ae11cd139e9ef469abffcd3bd4374bfda88bd2b. It is a read-only review, not owner approval.Raw local evidence is gitignored beneath
results/549_s2_2/; its tracked summary binds40raw artifacts by SHA-256. Initial failures and failed candidate generations are retained. Release trackSHA555f5134ce3d9b9c5670f60b98463a96e0ca769230b8e1e1e887f7c6f195c1ab; measurementSHA611739b2b9f2357abe265a6f5067984ed20d0b91e2d1e06d8246a9b3c25461aa. Replay verifies source, frozen inputs and binaries unchanged before/after.Final CI/delivery readback artifact
results/549_s2_2/final_ci_delivery_verification.jsonSHA-25657ebdec6d40bfc12a7987d98a2b803d4c6797c4d11059b3a15a910cce4158527binds the successful final-head PR runs, exact PR/base/head, then-Draft/unmerged state, empty closing references, clean source and remote refs. This is the historical pre-merge delivery record. The later authorized merge and successful main CI are recorded above; #549/#536/#550 remain open with bounded checkpoint writebacks.N03 residual and unverified items
ld-linux ... --audit ... entrypoint --model-bundleretains a pre-existing runtime-root derivation failure (/proc/self/exeresolves the loader, yielding/usr/share/saccade). This is a separate invocation coordinate, not installed launcher acceptance; no launcher/root policy change is included.caught=false. Equivalence remainsunproven.distribution.status=local-only,owner_confirmation=null.1f428c740f045c7c627667d82e75d7ba97af79d8, followed by its merge and successful main CI. This bounded checkpoint does not authorize new N03 techniques or implementation, S2-3 or any other excluded work.