Skip to content

docs(#549): correct why local_cli suites skip in CI (coverage reading) - #580

Merged
raylei50653 merged 1 commit into
mainfrom
docs/549-coverage-cli-wording
Oct 11, 2026
Merged

raylei50653 merged 1 commit into
mainfrom
docs/549-coverage-cli-wording

Conversation

@raylei50653

@raylei50653 raylei50653 commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

This PR fixes one wrong CI explanation in the S2-1 coverage map. It is docs-only and authorized for review only, not merge. The authorization is recorded verbatim in #550 comment 6106616992. The base is main@404fb5c429b93f54b4367f508ed6fcb8b362e6fc (the #579 merge).

Change (one string)

The file is docs/reference/model_bundle_s2_1_coverage_549.json, top-level reading, local_cli clause.

Text
Before (they skip in CI, which builds none)
After (they skip in CI: the pytest job has no build/shipping/saccade_track, and the C++ Core Build job that compiles saccade_track runs no CLI suite)

The conclusion, that the local_cli suites skip in CI, is unchanged. Only the reason is corrected.

Source evidence for the new wording

  • C++ Core Build compiles saccade_track but runs no pytest or CLI suite. It builds --target saccade_track from the root build (build-noopencv) in cpp_build.yml.
  • shipping-config-loader runs ctest only (the ci_ctest tests), on the standalone shipping/ project. That project has no saccade_track target: in shipping/CMakeLists.txt the target sits inside if(TARGET saccade_tracking), which only exists in the root build.
  • The pytest job builds nothing. The CLI suites carry pytest.mark.skipif(... "build/shipping/saccade_track not built"), for example tests/unit/test_saccade_track_model_bundle_cli.py.

Verification

  • Semantic diff check: after parsing both versions, every JSON field except the top-level reading is equal. git diff --stat shows 1 file, +1/−1.
  • Contract test: tests/contract/test_model_bundle_contract_549.py passed 30/30. It checks runs values and the test/case lists, not the reading text.
  • Local pre_push: scripts/pre_push.sh on the clean committed head 29f57ffd exited 0 (5650 passed, 52 skipped, 105 deselected, 5 xfailed).
  • Independent Codex read-only review of 29f57ffd: No findings. It confirmed the diff touches only that clause and checked the wording against both workflows, shipping/CMakeLists.txt and the CLI skip conditions. This is not a GitHub APPROVED review. The raw output is local only (gitignored results/549_cov_wording/).
  • PR CI 7/7 SUCCESS at head 29f57ffd: CI 38121406200.
    • Jobs: lockfile, shipping-config-loader, contracts, pytest (5393 passed, 249 skipped, 105 deselected, 4 xfailed), ruff, mypy, lint-typecheck.
    • The C++ build was not triggered, because this PR is docs-only. This is not reported as 8/8.

Not changed / not claimed

  • No changes to: runtime, C++, Python, tests, CI, allowlist, package, verification_matrix.json, or any other JSON field.
  • No new claims: no new verification claim (runtime, GPU, installed package, equivalence) and no change in status semantics. V5 stays UNRESOLVED, installed package UNVERIFIED, equivalence unproven, distribution local-only.
  • Merge: not authorized. The PR stays Draft until a separate owner merge authorization pinned to the final head.

🤖 Generated with Claude Code

The coverage map said CI "builds none". CI does compile saccade_track
(C++ Core Build) but runs no CLI suite there, and the pytest job has no
build/shipping/saccade_track, so the local_cli suites skip. Only the
top-level reading string changes; no verification claim is added.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@raylei50653

Copy link
Copy Markdown
Owner Author

Owner merge authorization (recorded verbatim)

The owner gave this authorization in the working session. It is copied here verbatim before merging so it can be traced. Pre-merge check:

  • head 29f57ffdea1460dd52397f0ad009e1523305d6d3 is unchanged;
  • base 404fb5c4 = origin/main;
  • the PR is MERGEABLE/CLEAN;
  • PR CI 38121406200 passed 7/7;
  • the diff is 1 file, +1/−1, and only the top-level reading differs (the other JSON fields are semantically equal).

Approved: PR #580 merge authorization, pinned to 29f57ffdea1460dd52397f0ad009e1523305d6d3.

批准將 PR #580 合併至 main,條件如下:

  1. 合併前確認: head 仍為上述 SHA、base 為 404fb5c4、MERGEABLE/CLEAN,且 diff 僅有核准的 JSON reading 字串。
  2. 合併方式: 先記錄本次授權,再將 Draft 轉為 Ready,使用 merge commit;禁止 squash、rebase 或額外修改。
  3. 合併後驗證: 確認 main CI 7/7 SUCCESS,並核對 headSha 等於 merge SHA。
  4. C++ Core Build: 本次是單純文字修正,不要求額外 workflow_dispatch。如有執行,須明確標記為 manual run,不得視為 push-triggered。
  5. 狀態回寫: main CI 通過後,更新 [Hub] SACCADE 工作總入口:進度、優先序、依賴與 checkpoint #550,記錄 merge SHA、parents、CI run、Codex review 結果及證據邊界。

本次 merge 不代表新增任何 runtime、GPU、package 或 equivalence 驗證。

V5 維持 UNRESOLVED,installed package 維持 UNVERIFIED,distribution 維持 local-only。

合併後將 #580 視為已收尾的文字修正。S2-2 與 S2-3 的優先順序仍待獨立決策,本授權不包含其實作。

@raylei50653
raylei50653 marked this pull request as ready for review October 11, 2026 07:51
@raylei50653
raylei50653 merged commit f63c9da into main Oct 11, 2026
7 checks passed
@raylei50653
raylei50653 deleted the docs/549-coverage-cli-wording branch November 13, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant