Removed possible reactivity between data and variables - #1369
Open
indykoning wants to merge 3 commits into
Open
Conversation
Jade-GG
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents a bug where the unfinished address form gets cleared if the e-mail address is filled in the meantime.
Steps to reproduce:
This only happens once, if you enter the firstname and lastname again. And amend your e-mail address it no longer changes.
It seems to be that
this.data = this.variablescauses unintended reactivity between some fields, circumventing the variables watcher. Causing it to see a change while externally no changes have occurred.This PR removes any possible reactivity between
this.variablesandthis.dataonly allowing the variables watcher to sync data from variables to data