Skip to content

Skip config re-apply and callbacks for unmodified reloads #5809

Description

@d3flex

following up #5397 (comment)

related issue: #3547

As #5397 (comment) says, ReadConfig doesn't return any signal to the caller, and that means the reload keeps doing unnecessary reconciling work when it could exit early, when nothing has changed. It also means the agentmanagement path re-fires its OnChange callbacks for a config the controller explicitly refused to adopt, so agent-deployment reconciliation acts on a change that never happened.

The task is to skip the re-apply in the controller-runtime path and skip the callback fan-out in the agentmanagement path, letting the controller be aware that there was no change.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

  • Status
    ✅ Done

Relationships

None yet

Development

No branches or pull requests

Issue actions