Skip to content

Use full windows for multi-year return metrics#530

Open
Whning0513 wants to merge 1 commit into
ranaroussi:mainfrom
Whning0513:fix-multiyear-metrics-window-516
Open

Use full windows for multi-year return metrics#530
Whning0513 wants to merge 1 commit into
ranaroussi:mainfrom
Whning0513:fix-multiyear-metrics-window-516

Conversation

@Whning0513

Copy link
Copy Markdown

Summary

  • use exact 3-year and 5-year cutoffs for the annualized return rows in reports.metrics()
  • keep the 10-year row on the same relativedelta(years=...) pattern
  • add a regression test that catches the previous one-month truncation

Closes #516

Testing

  • python -m pytest -q tests/test_reports.py -k "metrics_basic_mode or metrics_full_mode or metrics_with_rf or full_three_and_five_year_windows"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistencies Among 3Y (ann.), 5Y (ann.), and 10Y (ann.) Return Calculations

1 participant