Skip to content

audit: repair two merge losses in known-false-positives - #724

Merged
thedavidmeister merged 1 commit into
mainfrom
restore-kfp-merge-losses
Oct 16, 2026
Merged

thedavidmeister merged 1 commit into
mainfrom
restore-kfp-merge-losses

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

Repairs two losses in audit/known-false-positives.md found by checking every merge-conflict resolution on main since 2026-10-12 (git show --remerge-diff per merge, then each dropped line traced against main).

The other 37 suspect resolutions in that check were superseded on purpose (each traced to the commit that replaced the dropped lines); none lost content.

QA

  • Discriminating tests: n/a, documentation only. grep -c "excess <= 67. guard" drops from 2 to 1 (the Resolved by removal heading); deno fmt --check passes.
  • Mutations applied: n/a, no behaviour; not run with the adversarial-mutation-test skill.
  • Oracle: 93ed35b (removal of the guard and its replacement entry) and 3ffcfc9 (original preamble), read with git show.
  • Category check: the merge-loss check found two losses, both in this file; both are covered here.

🤖 Generated with Claude Code

9cbb237 re-added the equivalent-mutant section 93ed35b had replaced with
'Resolved by removal'; b1f6845 dropped the preamble from 3ffcfc9.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 75e91abb-6841-4cc7-99ee-caff20ef5e3c
📥 Commits

Reviewing files that changed from the base of the PR and between 01a9d1f and 3c26e8e.

📒 Files selected for processing: 1
  • audit/known-false-positives.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thedavidmeister
thedavidmeister merged commit a59d84d into main Oct 16, 2026
11 of 12 checks passed
@github-actions

Copy link
Copy Markdown

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

@linear

linear Bot commented Oct 16, 2026

Copy link
Copy Markdown

RAI-3477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant