Repository navigation
audit: repair two merge losses in known-false-positives - #724
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 49 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
Repairs two losses in
audit/known-false-positives.mdfound by checking every merge-conflict resolution on main since 2026-10-12 (git show --remerge-diffper merge, then each dropped line traced against main).## Equivalent mutant: pow carry path excess <= 67 guard ..., which 93ed35b had replaced with## Resolved by removal: ...when it removed that guard frompackRoundedSignificant. Main carried both: the stale one says the guard "changes nothing" and "has survived", butgrep 'excess <= 67' srcfinds nothing. TheResolved by removalsection stays.Resolved by removalentries the file now also holds.The other 37 suspect resolutions in that check were superseded on purpose (each traced to the commit that replaced the dropped lines); none lost content.
QA
grep -c "excess <= 67. guard"drops from 2 to 1 (theResolved by removalheading);deno fmt --checkpasses.git show.🤖 Generated with Claude Code