fix: pin qr to 0.5.5 to avoid breaking border=0 error#2680
Conversation
qr@0.6.0 introduced a breaking change that enforces a non-zero quiet zone border (ISO/IEC 18004 compliance). cuer@0.0.3 passes border=0, which causes QR code generation to throw at runtime when qr resolves to 0.6.0 via its ~0 range. Pin qr to 0.5.5 via pnpm.overrides until wevm/cuer ships a release that handles the new border requirement (wevm/cuer#11). Closes rainbow-me#2677
|
|
@0xAxiom is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f24d005a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "overrides": { | ||
| "@remix-run/dev>esbuild": "0.25.5" | ||
| "@remix-run/dev>esbuild": "0.25.5", | ||
| "qr": "0.5.5" |
There was a problem hiding this comment.
Apply qr pin in published dependency graph
Pinning qr under the monorepo root pnpm.overrides only affects installs of this repository, not consumers installing @rainbow-me/rainbowkit from npm, because that published package still depends on cuer (packages/rainbowkit/package.json dependency list) and does not carry the root override. In downstream apps, cuer can still resolve to qr@0.6.0, so the runtime border: 0 failure this commit targets will persist.
Useful? React with 👍 / 👎.
Problem
qr@0.6.0introduced a breaking change that enforces a non-zero quiet-zone border for ISO/IEC 18004 compliance.cuer@0.0.3hardcodesborder: 0when callingqr, which causes QR code generation to throw at runtime onceqrresolves to0.6.0(via its~0peer range).Fresh installs of RainbowKit 2.2.11 pull in
qr@0.6.0and hit the error immediately.Root cause
cuer@0.0.3depends onqr: "~0"→ resolves to0.6.0cuer/QrCode.tspassesborder: 0toqr→ throws in0.6.0Fix
Pin
qrto0.5.5viapnpm.overridesuntilcuerships a release compatible withqr@0.6.0.Testing
After this change,
pnpm installresolvesqr@0.5.5for thecuerpackage (verified in lockfile). QR code generation returns to normal.Closes #2677