Skip to content

fix: pin qr to 0.5.5 to avoid breaking border=0 error#2680

Open
0xAxiom wants to merge 1 commit into
rainbow-me:mainfrom
0xAxiom:fix/qr-0.6-border-zero
Open

fix: pin qr to 0.5.5 to avoid breaking border=0 error#2680
0xAxiom wants to merge 1 commit into
rainbow-me:mainfrom
0xAxiom:fix/qr-0.6-border-zero

Conversation

@0xAxiom

@0xAxiom 0xAxiom commented May 23, 2026

Copy link
Copy Markdown

Problem

qr@0.6.0 introduced a breaking change that enforces a non-zero quiet-zone border for ISO/IEC 18004 compliance. cuer@0.0.3 hardcodes border: 0 when calling qr, which causes QR code generation to throw at runtime once qr resolves to 0.6.0 (via its ~0 peer range).

Fresh installs of RainbowKit 2.2.11 pull in qr@0.6.0 and hit the error immediately.

Root cause

  • cuer@0.0.3 depends on qr: "~0" → resolves to 0.6.0
  • cuer/QrCode.ts passes border: 0 to qr → throws in 0.6.0
  • upstream fix tracked in fix: support qr 0.6 wevm/cuer#11 (not yet released)

Fix

Pin qr to 0.5.5 via pnpm.overrides until cuer ships a release compatible with qr@0.6.0.

"pnpm": {
  "overrides": {
    "qr": "0.5.5"
  }
}

Testing

After this change, pnpm install resolves qr@0.5.5 for the cuer package (verified in lockfile). QR code generation returns to normal.

Closes #2677

qr@0.6.0 introduced a breaking change that enforces a non-zero quiet
zone border (ISO/IEC 18004 compliance). cuer@0.0.3 passes border=0,
which causes QR code generation to throw at runtime when qr resolves
to 0.6.0 via its ~0 range.

Pin qr to 0.5.5 via pnpm.overrides until wevm/cuer ships a release
that handles the new border requirement (wevm/cuer#11).

Closes rainbow-me#2677
@0xAxiom 0xAxiom requested a review from a team as a code owner May 23, 2026 00:24
@changeset-bot

changeset-bot Bot commented May 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8f24d00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented May 23, 2026

Copy link
Copy Markdown

@0xAxiom is attempting to deploy a commit to the rainbowdotme Team on Vercel.

A member of the Team first needs to authorize it.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f24d005a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
"overrides": {
"@remix-run/dev>esbuild": "0.25.5"
"@remix-run/dev>esbuild": "0.25.5",
"qr": "0.5.5"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Apply qr pin in published dependency graph

Pinning qr under the monorepo root pnpm.overrides only affects installs of this repository, not consumers installing @rainbow-me/rainbowkit from npm, because that published package still depends on cuer (packages/rainbowkit/package.json dependency list) and does not carry the root override. In downstream apps, cuer can still resolve to qr@0.6.0, so the runtime border: 0 failure this commit targets will persist.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] qr version 0.6.0 throws errors when border=0

1 participant