fix(deepseek-v4): preserve grouped wo_a LoRA semantics - #2771
Open
zhoutong-hai wants to merge 1 commit into
Open
fix(deepseek-v4): preserve grouped wo_a LoRA semantics#2771zhoutong-hai wants to merge 1 commit into
zhoutong-hai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DeepSeek-V4
wo_ais not a single dense projection. It storesGindependent group weights in a flattened column-parallel matrix, and each input group must use only the matching output group.A generic
LoRALinearwrapper creates two problems:self.wo_a.weight, but the wrapper owns the base module underto_wrap;G × Gcross-group result, while the base operator uses only the group diagonal.Fix
Add a V4-specific grouped projection helper that:
adapter_forwardcontract;The helper is used only by V4
wo_a; other LoRA projections retain their generic wrappers.Validation
tests/fast/plugins/test_deepseek_v4_lora.py: 3 passed.Ordering
This PR should merge before #2772. That PR enables and wraps
wo_a, and therefore depends on this grouped execution path.Related rollout-engine execution PR: sgl-project/sglang#36579. V4 target registration and dimensions: sgl-project/sglang#36578.