fix(menu): defer outside pointer interactions on menu content#3976
Open
fayonation wants to merge 2 commits into
Open
fix(menu): defer outside pointer interactions on menu content#3976fayonation wants to merge 2 commits into
fayonation wants to merge 2 commits into
Conversation
Align menu dismissal timing with dialog by deferring pointer down outside handling. Prevents closing a dialog when dismissing a nested dropdown menu. Fixes radix-ui#3971. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 44faf6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deferPointerDownOutsideto menuDismissableLayer, matching Popover and Dialog behaviorFixes #3971
Problem
Clicking outside a DropdownMenu that is open inside a Dialog dismisses both the menu and the dialog, because the outside pointer event propagates to the dialog layer.
Test plan
pnpm vitest run packages/react/dismissable-layer/src/dismissable-layer.test.tsxMade with Cursor