fix(popper): allow virtualRef to accept RefObject<Measurable | null> for React 19#3969
Open
patrickwehbe wants to merge 1 commit into
Open
fix(popper): allow virtualRef to accept RefObject<Measurable | null> for React 19#3969patrickwehbe wants to merge 1 commit into
patrickwehbe wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: e49b93e The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PopperAnchor'svirtualRefprop is typed asReact.RefObject<Measurable>, but in React 19useRef<Measurable>(null)returnsRefObject<Measurable | null>. As a result, passing a virtual ref (the documented anchoring pattern) fails to type-check under React 19.This widens the prop type to
React.RefObject<Measurable | null>. The change is type-only and internally safe:anchorRefis alreadyMeasurable | null(useRef<Measurable | null>(null)).virtualRef.currentis read into that slot, and rendering only branches onvirtualReftruthiness.No runtime behavior changes, and existing callers passing a non-null ref remain assignable.
Closes #3635