fix(tooltip): don't reopen on window/tab refocus (#1800)#3964
Open
effinrich wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 0886bef The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1800. A
Tooltipwhose trigger is focused reopens itself when you switch away from and back to the browser tab (or minimize/restore the window).Root cause
Returning to the tab refocuses the previously-active element, firing a synthetic
focusevent on the trigger.TooltipTrigger'sonFocusopens on any non-pointer focus, so it can't distinguish that refocus from a genuine keyboard focus — and opens the tooltip.Fix
Track window blur via a ref (mirrors the recently-merged window-blur handling for menus, #3938). When the trigger is focused immediately after the window was blurred, treat it as the tab/window regaining focus and skip opening — consuming the flag so the next genuine focus opens normally.
Test
Adds a regression test using
window.dispatchEvent(new FocusEvent('blur'))thenfireEvent.focus(trigger), assertingdata-statestaysclosed, and that a subsequent genuine focus still opens. Changeset included (patch:@radix-ui/react-tooltip,radix-ui).Tradeoff (open to feedback)
If the window is blurred and the user later keyboard-focuses a different, never-focused trigger, that trigger's first focus is suppressed once. Minor — happy to switch to a
requestAnimationFrame-on-window-focusreset to eliminate it if preferred.