cli/tests: Wait for seed discovery after clone - #565
Open
Xeonacid wants to merge 1 commit into
Open
Conversation
`git_push_canonical` clones the repository as Bob and then immediately runs `git push` as Alice, expecting "Synced with 1 seed(s)". `clone` announces Bob's inventory, but Alice only treats Bob as a seed after that announcement is applied to her routing table. On a slower host the reactor can still be busy when Alice looks up seeds, so she reports "No seeds found". Wait until Alice's routing table contains Bob for the repository before pushing. Apply the same wait to the lightweight-tags variant, which uses the same setup. Signed-off-by: Xeonacid <h.dwwwwww@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git_push_canonicalclones the repository as Bob and then immediately runsgit pushas Alice, expectingSynced with 1 seed(s).cloneannounces Bob's inventory, but Alice only treats Bob as a seed after that announcement is applied to her routing table. On a slower host the reactor can still be busy when Alice looks up seeds, so she reportsNo seeds found.This showed up on native riscv64 (
commands::git::git_push_canonical): Alice'sSeedslookup ran before Bob's inventory announcement was applied, returning 0 connected seeds.Wait until Alice's routing table contains Bob for the repository before pushing. Apply the same wait to the lightweight-tags variant, which uses the same setup.