Skip to content

Fix SRP auth response - #124

Open
3oris wants to merge 1 commit into
qwigo:masterfrom
moia-dev:fix-spr-auth-response
Open

Fix SRP auth response#124
3oris wants to merge 1 commit into
qwigo:masterfrom
moia-dev:fix-spr-auth-response

Conversation

@3oris

@3oris 3oris commented Jul 12, 2018

Copy link
Copy Markdown

@3oris 3oris changed the title Fix SPR auth response Fix SRP auth response Jul 12, 2018
@3oris

3oris commented Jul 12, 2018

Copy link
Copy Markdown
Author

Cannot test due to

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions

@mingofmongo mingofmongo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @3oris , I can confirm that your fix works! Just tried it out with a client app that has client secret. Internal username (AWS's "sub") and self.username (email) are indeed different.

@bwindsor

Copy link
Copy Markdown

I can also confirm that this fix works. Please could it be merged?

@blueskycorner

Copy link
Copy Markdown

Any update ?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SRP doesn't authenticate reliably with client secret

4 participants