Skip to content

Revert "id3v1: save comment when COMM frame is stored under its HashKey" - #713

Merged
lazka merged 3 commits into
quodlibet:mainfrom
lazka:comm-roundtrip
Jun 24, 2026
Merged

Revert "id3v1: save comment when COMM frame is stored under its HashKey"#713
lazka merged 3 commits into
quodlibet:mainfrom
lazka:comm-roundtrip

Conversation

@lazka

@lazka lazka commented Jun 22, 2026

Copy link
Copy Markdown
Member

This reverts commit e2354c1.

lazka added 2 commits June 22, 2026 20:42
See quodlibet#709 (comment)
It takes any COMM and writes it to id3v1 which when read back means
the COMM gets duplicated.

@phw phw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to revert this then.

But we should re-open #660 afterwards.

Comment thread tests/test_id3.py Outdated
@lazka
lazka merged commit 4a43d97 into quodlibet:main Jun 24, 2026
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants