Fix GPT-OSS blocked prefill cache reads and head-par prefill blocking - #1302
Draft
smedhe wants to merge 1 commit into
Draft
Fix GPT-OSS blocked prefill cache reads and head-par prefill blocking#1302smedhe wants to merge 1 commit into
smedhe wants to merge 1 commit into
Conversation
Signed-off-by: smedhe <smedhe@qti.qualcomm.com>
smedhe
marked this pull request as draft
September 2, 2026 06:48
kdulla
requested changes
Sep 7, 2026
| "num_kv_blocks": 2, | ||
| "num_q_blocks": 2, | ||
| "ctx_len": args.ctx_len, | ||
| "moe_config": {"expert_prefill_chunk_size": args.moe_prefill_packed_chunk_size}, |
Contributor
There was a problem hiding this comment.
should be expert_parallel_chunk_size
| query_states, key_states = qeff_apply_rotary_pos_emb(query_states, key_states, cos_cached, sin_cached) | ||
|
|
||
| blocking_config = getattr(self, "attn_blocking_config", AttentionBlockingConfig()) | ||
| use_blocking = blocking_config is not None and blocking_config.mode.is_prefill and (self.sliding_window is None) |
Contributor
There was a problem hiding this comment.
we should raise an error if we do a blocking mode that is not prefill specific, not just skip it like this code does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary