Repository navigation
Fix typing lag with high sample counts - #4132
Merged
Merged
Conversation
The playground re-rendered the entire viewer tree on every keystroke: the simulation object was rebuilt on each render, defeating memoization downstream. Memoize it, stabilize the randomizeSeed callback, and wrap ViewerWithMenuBar in React.memo. Measured (headless chromium, 15-dist model, autorun off): 21.6ms/char at 100k samples before, 6.5ms/char after (same as 1k baseline). Fixes #4057 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: cdfe141 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With auto-run off, typing was still laggy at high sample counts because the playground re-rendered the whole viewer tree on every keystroke: the simulation object was rebuilt each render, defeating memoization. This memoizes it, stabilizes the seed-randomize callback, and wraps the viewer in React.memo.
Measured with headless Chromium on a 15-distribution model, auto-run off: 21.6ms/keystroke at 100k samples before, 6.5ms after — same as the 1k-sample baseline. Verified auto-run mode still re-simulates and renders new variables.
Fixes #4057
🤖 Generated with Claude Code