Skip to content

Ask for confirmation before deleting a model - #4127

Merged
michaelr524 merged 2 commits into
mainfrom
fix/delete-model-confirmation
Jul 4, 2026
Merged

michaelr524 merged 2 commits into
mainfrom
fix/delete-model-confirmation

Conversation

@michaelr524

@michaelr524 michaelr524 commented Jul 4, 2026 •

Copy link
Copy Markdown
Collaborator

The Delete button in the model settings dropdown deleted the model immediately. It now opens a confirmation modal first, using the same pattern as other delete actions (e.g. question sets).

The modal's submit button uses a new optional submitTheme prop (red "alert" theme for destructive actions).

Fixes #4056

🤖 Generated with Claude Code

Fixes #4056

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@michaelr524
michaelr524 requested review from OAGr and berekuk as code owners July 4, 2026 18:21
@github-project-automation github-project-automation Bot moved this to 🆕 To prioritize in Overview Jul 4, 2026
@vercel

vercel Bot commented Jul 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
metaforecast Ready Ready Preview Jul 4, 2026 6:47pm
quri-hub Ready Ready Preview Jul 4, 2026 6:47pm
quri-ui Ready Ready Preview Jul 4, 2026 6:47pm
squiggle-components Ready Ready Preview Jul 4, 2026 6:47pm
squiggle-website Ready Ready Preview Jul 4, 2026 6:47pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fermi-contest-2025-02 Ignored Ignored Preview Jul 4, 2026 6:47pm

Request Review

@changeset-bot

changeset-bot Bot commented Jul 4, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 40830a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

This branch was successfully deployed

6 active (1 outdated) deployments
Preview – quri-hub — 40830a14 Deployed Jul 4, 2026 by vercel[bot]
Preview – squiggle-website — 40830a14 Deployed Jul 4, 2026 by vercel[bot]
Preview – metaforecast — 40830a14 Deployed Jul 4, 2026 by vercel[bot]
Preview – squiggle-components — 40830a14 Deployed Jul 4, 2026 by vercel[bot]
Preview – quri-ui — 40830a14 Deployed Jul 4, 2026 by vercel[bot]
Preview – fermi-contest-2025-02 — 1adadc12 Deployed Jul 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

"Delete" button for models does not ask to confirm

1 participant