refactor(crux): delete unimported modules and completed one-shot scripts - #4995
Conversation
23 modules nothing imports, and 25 one-shot migration/backfill scripts whose migrations have landed. Recoverable from git history. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WXiHX1a9DEuvwydgTP43ZE
|
Warning Review limit reachedNext included review available in 38 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (52)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Protected paths modifiedThis PR modifies files that affect agent behavior, CI, or validation rules. Modified protected files:
|
|
Generated by Claude Code |
Test Coverage Report
Coverage is advisory only — no thresholds enforced. Generated by |
Removes about 11k lines of crux code that nothing uses: 23 modules with no importers, and 25 one-shot migration or backfill scripts whose migrations have already landed. Pure deletion plus three comment/doc edits; all of it is recoverable with
git show e35e704fa:<path>.Modules with no importers (repo-wide import graph + grep for string/script-map references):
lib/validation/mermaid-checks.ts,lib/issue-scoring.ts,lib/matrix-dimensions.ts,lib/matrix-snapshot.ts(the last three with their tests),lib/calc-evaluator.ts,lib/entity-names.ts,lib/normalize-entity-slugs.ts,lib/dispatch-prompt-template.ts,entity-matrix/scan.tsandgaps.ts,authoring/orchestrator/tools/add-references.tsandenrich/enrich-references.ts(registry.tsalready says the tool was removed),generate/generate-research-reports.ts(a no-op),evals/pilot.ts, and six unused barrelindex.tsfiles.Completed one-shot scripts in
crux/scripts/(FISA-702 seeding, stable-id / slug / fact-id migrations, QUA-503 mapping and sweep already applied as migration 0182, resource title fixes, and others) plusauthoring/bootstrap-update-frequency.tsandreassign-update-frequency.ts.sync-careers-to-personnelwas already broken: its inputcareer-data.jsondoes not exist.Kept on purpose:
check-pr-merge-eligible(a hook uses it),refresh-frameworks(a workflow runs it), reusable tools (scrape-ailabwatch,fetch-forum-posts,check-source-urls,triage-footnotes,fix-contradicted-facts), andstableid-migration-map.json(SQL provenance).Verified on the tree with these deletions: crux typecheck error set unchanged; crux vitest passes (only tests of deleted modules are gone);
node crux/build.mjsandpnpm crux --helpOK; content gate passes; pre-push gate passed. Touchescrux/commands/so it needsgate:rules-ok.🤖 Generated with Claude Code
https://claude.ai/code/session_01WXiHX1a9DEuvwydgTP43ZE
Generated by Claude Code