Repository navigation
[reproduce] Preserve linker inputs when reproduce link fails - #2068
Draft
Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Draft
Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Conversation
Steven Ramirez Rosa (Steven6798)
requested review from
Parth (parth-07) and
Shankar Easwaran (quic-seaswara)
as code owners
October 5, 2026 17:11
Parth (parth-07)
approved these changes
Oct 5, 2026
Shankar Easwaran (quic-seaswara)
requested changes
Oct 6, 2026
| // namespecs that have an explicit mapping entry, preserving normal mapped | ||
| // link behavior. | ||
| if (PConfig.options().hasMappingFile() && !isInternal() && | ||
| (Type != Input::Namespec || PConfig.hasMappingForFile(FileName))) |
Contributor
There was a problem hiding this comment.
Can this condition be simplified or made into a seperate function ?
Input::resolveReproducePath() ?
This will allow the critical code without reproduce unaffected.
Contributor
Author
There was a problem hiding this comment.
Sounds good.
Contributor
Author
There was a problem hiding this comment.
Let me know if my latest change is what you were looking for.
| @@ -1763,6 +1770,8 @@ bool GnuLdDriver::processReproduceOption( | |||
| break; | |||
| } | |||
Contributor
There was a problem hiding this comment.
I could not follow this.
Contributor
Author
There was a problem hiding this comment.
We cannot just return because we failed to resolve the action. That's how we end up without the input file in the reproduce.
Steven Ramirez Rosa (Steven6798)
marked this pull request as draft
October 6, 2026 18:40
Capture linker scripts and unresolved namespecs when input activation fails so the reproduce response preserves the original failure. Avoid applying mapping-file resolution to unmapped replay namespecs while retaining normal mapped namespec behavior. Fix: qualcomm#1014 Signed-off-by: Steven Ramirez Rosa <ramirezr@qti.qualcomm.com>
Steven Ramirez Rosa (Steven6798)
force-pushed
the
issue-1014
branch
from
October 6, 2026 19:15
d73074a to
2f5b3d9
Compare
Steven Ramirez Rosa (Steven6798)
marked this pull request as ready for review
October 6, 2026 19:15
Steven Ramirez Rosa (Steven6798)
requested a review
from Shankar Easwaran (quic-seaswara)
October 6, 2026 19:16
quic-areg
reviewed
Oct 6, 2026
| arg->getValue(), eld::SearchDirs::SearchInputType::Script)) | ||
| ResolvedPath = Resolved->native(); | ||
| if (!ResolvedPath.empty()) | ||
| outputTar->createAndAddScriptFile(arg->getValue(), ResolvedPath); |
Contributor
There was a problem hiding this comment.
Is it possible that we add this script twice? What about scripts that include other scripts?
Contributor
Author
There was a problem hiding this comment.
I will look into this. Thanks!
Steven Ramirez Rosa (Steven6798)
marked this pull request as draft
October 6, 2026 20:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture linker scripts and unresolved namespecs when input activation fails so the reproduce response preserves the original failure. Avoid applying mapping-file resolution to unmapped replay namespecs while retaining normal mapped namespec behavior.
Fix: #1014