Skip to content

Add support for --[no-]undefined-version - #1917

Merged
Parth (parth-07) merged 1 commit into
qualcomm:mainfrom
parth-07:UndefinedVersion
Oct 6, 2026
Merged

Add support for --[no-]undefined-version#1917
Parth (parth-07) merged 1 commit into
qualcomm:mainfrom
parth-07:UndefinedVersion

Conversation

@parth-07

@parth-07 Parth (parth-07) commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

This commit adds --[no-]undefined-version option. When --no-undefined-version is passed, then the linker reports an error if an exact version script pattern has no match. Default behaviour is --undefined-version.

Resolves #1133

@parth-07
Parth (parth-07) force-pushed the UndefinedVersion branch 2 times, most recently from bbee644 to 16c6274 Compare September 24, 2026 09:46
@parth-07
Parth (parth-07) marked this pull request as draft September 24, 2026 14:57
@parth-07
Parth (parth-07) marked this pull request as ready for review September 24, 2026 15:28
@parth-07

Parth (parth-07) commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

Shankar Easwaran (@quic-seaswara) Steven Ramirez Rosa (@Steven6798) I have removed the ELD_ENABLE_SYMBOL_VERSIONING header guard from #include "include/eld/Diagnostics/DiagSymbolVersioning.inc" as this patch adds a symbol versioning-related diagnostic that is used by both the symbol-versioning code and non-symbol-versioning code. Please let me know if it is okay. The other alternatives are either to disable the --undefined-version feature for symbol versioning disabled builds, or move the new diagnostic to a file other than DiagSymbolVersioning.inc. Though, DiagSymbolVersioning is a good fit for this new diagnostic.

@Steven6798

Steven Ramirez Rosa (Steven6798) commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Shankar Easwaran (Shankar Easwaran (@quic-seaswara)) Steven Ramirez Rosa (Steven Ramirez Rosa (@Steven6798)) I have removed the ELD_ENABLE_SYMBOL_VERSIONING header guard from #include "include/eld/Diagnostics/DiagSymbolVersioning.inc" as this patch adds a symbol versioning-related diagnostic that is used by both the symbol-versioning code and non-symbol-versioning code. Please let me know if it is okay. The other alternatives are either to disable the --undefined-version feature for symbol versioning disabled builds, or move the new diagnostic to a file other than DiagSymbolVersioning.inc. Though, DiagSymbolVersioning is a good fit for this new diagnostic.

I don't see any issues with this. Do what you think it's best.

@parth-07
Add support for --[no-]undefined-version
29920ee 
This commit adds --[no-]undefined-version option. When
--no-undefined-version is passed, then the linker reports an error if an
exact version script pattern has no match. Default behaviour is
--undefined-version.

Resolves qualcomm#1133

Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
@parth-07
Parth (parth-07) merged commit 6b85640 into qualcomm:main Oct 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Steven6798 Steven Ramirez Rosa (Steven6798) Steven6798 approved these changes
@quic-areg quic-areg quic-areg approved these changes
@quic-seaswara Shankar Easwaran (quic-seaswara) quic-seaswara approved these changes

Assignees

No one assigned

Labels

ignore-for-release-notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

eld does not support --[no]-undefined-version

4 participants

@parth-07 @Steven6798 @quic-areg @quic-seaswara