Report error when version script node has local block before the global - #1588
Parth (parth-07) wants to merge 1 commit into
Conversation
|
|
||
| It is an error for a ``local:`` block to appear before a ``global:`` block in | ||
| the same version node. | ||
|
|
There was a problem hiding this comment.
can we add a attention syntax here
.. attention::
There was a problem hiding this comment.
is there any other kinds of errors that version script parser detects and silently errors out?
There was a problem hiding this comment.
can we add a attention syntax here
The file has now been changed to markdown file. I have added the markdown-alternative :::{note} syntax here.
There was a problem hiding this comment.
is there any other kinds of errors that version script parser detects and silently errors out?
If version script node is getting parsed and there has been any other error in the script parsing then the version script node parsing also unnecessarily fails due to the below highlighted code:
VersionScriptBlock *VersionScriptNode::switchToGlobal() {
if (MLocal && !MGlobal) {
MHasErrorDuringParsing = true;
return nullptr;
}
+ if (MHasErrorDuringParsing)
+ return nullptr;
...I believe that this should be addresses separately.
14418e8 to
2bafbca
Compare
2bafbca to
b885d2a
Compare
b885d2a to
40c53a0
Compare
This commit updates ScriptParser to report error when a version script node contains local block before the global block. Resolves qualcomm#1582 Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
40c53a0 to
adad528
Compare
This branch has not been deployed
3 participants
This commit updates ScriptParser to report error when a version script node contains local block before the global block.
Resolves #1582