Add UNICODE_TAP_DELAY to allow a different tap delay for Unicode - #26361
Draft
NapOli1084 wants to merge 1 commit into
Draft
Add UNICODE_TAP_DELAY to allow a different tap delay for Unicode#26361NapOli1084 wants to merge 1 commit into
UNICODE_TAP_DELAY to allow a different tap delay for Unicode#26361NapOli1084 wants to merge 1 commit into
Conversation
NapOli1084
commented
Jul 24, 2026
| // correctly in the shifted case. | ||
| if (unicode_config.input_mode == UNICODE_MODE_LINUX && unicode_saved_led_state.caps_lock) { | ||
| tap_code(KC_CAPS_LOCK); | ||
| tap_code(KC_CAPS_LOCK); // Note: uses TAP_HOLD_CAPS_DELAY |
Contributor
Author
There was a problem hiding this comment.
I kept KC_CAPS_LOCK taps as-is to avoid changing the current behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
UNICODE_TAP_DELAYdefine that allows configuring a different tap delay for Unicode.It defaults to
TAP_CODE_DELAY, which means the default behavior is unchanged.Users may define it in their
config.hto configure a different delay.Note: I haven't updated the doc and tests yet, I'll do so if we agree on the solution.
Types of Changes
Issues Fixed or Closed by This PR
Checklist